Skip to content

Conversation

cmcginley-splunk
Copy link
Contributor

@cmcginley-splunk cmcginley-splunk commented Aug 15, 2024

Context

  • in Adding risk message validation++ #92 we introduced a bugfix which shaved an unnecessary extra 60s wait before starting the backoff timer
  • this resulted in less overall time for those detections which are sluggish to generate risk events, causing some intermittent failures

Code changes

  • we bumped the total backoff timer by 60s (from 210s to 270s)

@cmcginley-splunk cmcginley-splunk self-assigned this Aug 15, 2024
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with this change. This amount gives us a bit larger margin and should cut our failures to 0. If we continue to see timing issues, we can bump this even higher.

@pyth0n1c pyth0n1c merged commit 9ae8459 into main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants