Skip to content

Hotfix: Bumping integration testing timeout to compensate for recent bugfix #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Hotfix: Bumping integration testing timeout to compensate for recent bugfix #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63005e9
bumping integration testing timeout to compensate for recent bugfix
cmcginley-splunk Aug 15, 2024
1d85965
bumping to 300s to accommodate some of the rarer outliers
cmcginley-splunk Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions contentctl/objects/correlation_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ class TimeoutConfig(int, Enum):
# base amount to sleep for before beginning exponential backoff during testing
BASE_SLEEP = 60

# max amount to wait before timing out during exponential backoff
MAX_SLEEP = 210
# NOTE: Some detections take longer to generate their risk/notables than other; testing has
# shown 270s to likely be sufficient for all detections in 99% of runs; however we have
# encountered a handful of transient failures in the last few months. Since our success rate
# is at 100% now, we will round this to a flat 300s to accomodate these outliers.
# Max amount to wait before timing out during exponential backoff
MAX_SLEEP = 300


# TODO (#226): evaluate sane defaults for timeframe for integration testing (e.g. 5y is good
Expand Down