Require mitre/cti repo for enrichments #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require checkout of mitre/cti repo.
to how enrichment is done. It now works as expected and the proper errors are thrown for AtomicEnrichment depending on the --enrichments cli setting.
patel-bhavin
approved these changes
Sep 18, 2024
|
This PR is tested and worked great! Lets merge this and create a pip release : I have also made the the CI changes in security content Github- splunk/security_content#3133 and Gitlab - MR number 1660 need to bump contentctl release version to 4.3.5 |
|
I will create v4.3.5 release with these changes after merging them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update enrichments to always require checkout of
mitre/cti repo.
This PR is a simpler version of the following PR, which will be deprecated
as it involved more complexity than required:
#276