CSPL-663 Optimize deployment of Splunk apps on SHC

Add a new parameter defaultsUrlApps to install apps listed here only on Standalone,
SHC Deployer, and IDC CM.  This parameter would be ignored on individual SHs and indexers
in a clustered environment as the install of app there would be handled by bundle push
from the deployer or CM.

Author: jryb

pkg/apis/enterprise/v1beta1/common_types.go

@@ -58,6 +58,12 @@ type CommonSplunkSpec struct {
 	// Full path or URL for one or more default.yml files, separated by commas
 	DefaultsURL string `json:"defaultsUrl"`
 
+	// Full path or URL for one or more default.yml files specific to App install, separated by commas
+	// This is meant as a temporary fix until the SHC Deployer has its own CRD.  The defaults listed here will
+	// only be installed on a standalone, or a SHC Deployer or IDC CM to be pushed to SH/IDXs in a cluster.
+	// This parameter is ignored on individual SHs or IDXs within a cluster
+	DefaultsURLApps string `json:"defaultsUrlApps"`
+
 	// Full path or URL for a Splunk Enterprise license file
 	LicenseURL string `json:"licenseUrl"`
 

pkg/splunk/enterprise/configuration.go

@@ -590,6 +590,13 @@ func updateSplunkPodTemplateWithConfig(client splcommon.ControllerClient, podTem
 
 	// prepare defaults variable
 	splunkDefaults := "/mnt/splunk-secrets/default.yml"
+	// Check for apps defaults and add it to only the standalone or deployer/cm instances
+	if spec.DefaultsURLApps != "" &&
+		(instanceType == SplunkDeployer ||
+			instanceType == SplunkStandalone ||
+			instanceType == SplunkClusterMaster) {
+		splunkDefaults = fmt.Sprintf("%s,%s", spec.DefaultsURLApps, splunkDefaults)
+	}
 	if spec.DefaultsURL != "" {
 		splunkDefaults = fmt.Sprintf("%s,%s", spec.DefaultsURL, splunkDefaults)
 	}