CSPL-3480 Add SecurityContext to IndexerCluster CRD template #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13585981453Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 13630576278Details
💛 - Coveralls |
kasiakoziol
force-pushed
the
feature/CSPL_3480_indexer_security_context_for_pvc
branch
from
cad5bcc to
483e287
Compare
| More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ | ||
| type: object | ||
| type: object | ||
| securityContext: |
There was a problem hiding this comment.
Could you please schedule a meeting to review these changes? Any CRD changes should be thoroughly reviewed. For any feature or CRD changes, we require a Requirements Document or Design Document, which should be reviewed during the meeting before the PR is raised. We can create a spike to gather all the necessary requirements beforehand.
There was a problem hiding this comment.
@vivekr-splunk I raised it on our internal channel. It looks like we might not need this change any more. Based on the discussion, I will either follow your feedback or decline the PR.
|
This is already implemented as described under #1416 comment section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.