Skip to content

CSPL-3480 Add SecurityContext to IndexerCluster CRD template #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

CSPL-3480 Add SecurityContext to IndexerCluster CRD template #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bacc54
CSPL-3480 Add SecurityContext to IndexerCluster CRD template
kasiakoziol Feb 28, 2025
483e287
Merge branch 'develop' into feature/CSPL_3480_indexer_security_contex…
kasiakoziol Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions bundle/manifests/enterprise.splunk.com_indexerclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,42 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
securityContext:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please schedule a meeting to review these changes? Any CRD changes should be thoroughly reviewed. For any feature or CRD changes, we require a Requirements Document or Design Document, which should be reviewed during the meeting before the PR is raised. We can create a spike to gather all the necessary requirements beforehand.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekr-splunk I raised it on our internal channel. It looks like we might not need this change any more. Based on the discussion, I will either follow your feedback or decline the PR.

description: Security configuration on the pod level.
properties:
runAsUser:
anyOf:
- type: integer
- type: string
description: |-
User ID for all processes in any containers in the pod.
x-kubernetes-int-or-string: true
runAsGroup:
anyOf:
- type: integer
- type: string
description: |-
Primary Group ID for all processes within any containers of the pod.
Root by default.
x-kubernetes-int-or-string: true
fsGroup:
anyOf:
- type: integer
- type: string
description: |-
Supplementary Group ID for all processes within any containers of the pod.
x-kubernetes-int-or-string: true
fsGroupChangePolicy:
description: |-
Behavior for changing ownership and permissions of the volume.
Applies only to volume types that support fsGroup controlled ownership and permissions.
Can be either OnRootMismatch or Always (default).
default: Always
enum:
- OnRootMismatch
- Always
type: string
type: object
schedulerName:
description: Name of Scheduler to use for pod placement (defaults
to “default-scheduler”)
Expand Down
36 changes: 36 additions & 0 deletions config/crd/bases/enterprise.splunk.com_indexerclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,6 +1352,42 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
securityContext:
description: Security configuration on the pod level.
properties:
runAsUser:
anyOf:
- type: integer
- type: string
description: |-
User ID for all processes in any containers in the pod.
x-kubernetes-int-or-string: true
runAsGroup:
anyOf:
- type: integer
- type: string
description: |-
Primary Group ID for all processes within any containers of the pod.
Root by default.
x-kubernetes-int-or-string: true
fsGroup:
anyOf:
- type: integer
- type: string
description: |-
Supplementary Group ID for all processes within any containers of the pod.
x-kubernetes-int-or-string: true
fsGroupChangePolicy:
description: |-
Behavior for changing ownership and permissions of the volume.
Applies only to volume types that support fsGroup controlled ownership and permissions.
Can be either OnRootMismatch or Always (default).
default: Always
enum:
- OnRootMismatch
- Always
type: string
type: object
schedulerName:
description: Name of Scheduler to use for pod placement (defaults
to “default-scheduler”)
Expand Down
4 changes: 4 additions & 0 deletions helm-chart/splunk-enterprise/templates/enterprise_v4_indexercluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ items:
{{- end }}
{{- with $.Values.indexerCluster.resources }}
resources:
{{ toYaml . | indent 6 }}
{{- end }}
{{- with $.Values.indexerCluster.securityContext }}
securityContext:
{{ toYaml . | indent 6 }}
{{- end }}
{{- with $.Values.indexerCluster.serviceTemplate }}
Expand Down
4 changes: 4 additions & 0 deletions helm-chart/splunk-enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,10 @@ indexerCluster:
# memory: "12Gi"
# cpu: "24"

# Set security context for Indexer Cluster pods
# Reference: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-pods
securityContext: {}

serviceAccount: ""

# ServiceTemplate is a template used to create Kubernetes services
Expand Down
36 changes: 36 additions & 0 deletions helm-chart/splunk-operator/crds/enterprise.splunk.com_indexerclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,42 @@ spec:
More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
type: object
type: object
securityContext:
description: Security configuration on the pod level.
properties:
runAsUser:
anyOf:
- type: integer
- type: string
description: |-
User ID for all processes in any containers in the pod.
x-kubernetes-int-or-string: true
runAsGroup:
anyOf:
- type: integer
- type: string
description: |-
Primary Group ID for all processes within any containers of the pod.
Root by default.
x-kubernetes-int-or-string: true
fsGroup:
anyOf:
- type: integer
- type: string
description: |-
Supplementary Group ID for all processes within any containers of the pod.
x-kubernetes-int-or-string: true
fsGroupChangePolicy:
description: |-
Behavior for changing ownership and permissions of the volume.
Applies only to volume types that support fsGroup controlled ownership and permissions.
Can be either OnRootMismatch or Always (default).
default: Always
enum:
- OnRootMismatch
- Always
type: string
type: object
schedulerName:
description: Name of Scheduler to use for pod placement (defaults
to “default-scheduler”)
Expand Down
Loading