CSPL-534: Fix unnecessary pod recycle during scale up/down #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-splunk
requested review from
akondur,
sgontla,
kashok-splunk and
smohan-splunk
kashok-splunk
previously approved these changes
Dec 3, 2020
jryb
reviewed
Dec 3, 2020
jryb
approved these changes
Dec 4, 2020
akondur
approved these changes
Dec 7, 2020
sgontla
suggested changes
Dec 8, 2020
sgontla
approved these changes
Dec 8, 2020
smohan-splunk
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem of unnecessary pod resets/recycles during scale up/down of splunk resources. As part of this solution, as soon as we try to scale up/down pods, we now update the
pod-revision-hashlabel on pods to matchupdateRevisionof StatefulSet. This prevents the recycle of pods based onpod-revision-hashmismatch of pods.