CSPL-694: Fix skipping of pod recycle during changes to CR spec #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets the bug introduced during the implementation of 193, where if you change the CR spec(such as
imagein the case of an upgrade), then only the latest pod gets recycled to come up with the updated version but not the other replicas.To fix this we have now introduced another field
IsScalinginStatusfield of indexercluster and search head cluster statefulsets to track if we are in the process of scaling and only then update the pod-revision-hash label for the pods, else just go through with the recycling of pods.