Splunk Operator 1.0.3 release #511

github-actions · 2021-09-14T22:34:56Z

Automated Pull Request for Splunk Operator Release 1.0.3
Changes added to docs/ChangeLog-NEW.md. Please filter and update ChangeLog.md

smohan-splunk · 2021-09-15T00:22:29Z

docs/ChangeLog-NEW.md

@@ -0,0 +1,21 @@
+ab073ce Moved action file to right location (#510)


@pdhanoyasplunk Can you please remind me what the plan is for Changelog? Ideally we want to update the existing file

akondur

@pdhanoyasplunk I would double check the following:

All the occurrences of Splunk Enterprise version changes
All the occurrences of Splunk operator version changes
Why is there changes in the CRD's it self? Shouldn't have that been handled before hand?

akondur · 2021-09-15T00:28:32Z

deploy/crds/enterprise.splunk.com_clustermasters_crd.yaml

  versions:
  - additionalPrinterColumns:
-    - description: Status of cluster master
+    - description: Status of cluster manager


Aren't these changes supposed to be independent of the release changes? Not sure if I am missing something. Are we making the changes from master to manager explicitly here along with the release changes?

Seems like this is a missing change on Develop. I can see the same on my local build.

This wasn't intended. I believe is caused because of this change.

It shouldn't be harmful but we might want to roll back to keep it consistent for the release. @pdhanoyasplunk , @smohan-splunk. If we roll back we'll have to rerun the workflow. What do you think?

I agree, although not harmful, its better we roll back since CRD version doesn't change this release. We can bring these back with MC CRD changes post 1.0.3 release

After further discussion, we decided to keep the changes

akondur · 2021-09-15T00:34:27Z

docs/Install.md


 ```
-wget -O splunk-operator.yaml https://github.com/splunk/splunk-operator/releases/download/1.0.2/splunk-operator-install.yaml
+wget -O splunk-operator.yaml https://github.com/splunk/splunk-operator/releases/download/1.0.3/splunk-operator-install.yaml


Aren't there other places where the 1.0.2 to 1.0.3 need to be changed? Check L21 below. Here is the helper PR to develop for 1.0.0GA release. It would be great if we do an apples to apples comparison once. It's easy to miss semantic changes I guess.

gaurav-splunk · 2021-09-15T00:42:26Z

deploy/olm-catalog/splunk/1.0.3/splunk.v1.0.3.clusterserviceversion.yaml

+  - supported: true
+    type: SingleNamespace
+  - supported: false
+    type: MultiNamespace


Just a thought, I think at some point in future we should also support watching multiple namespaces(as in watching only specific namespaces rather than all namespaces)

sgontla · 2021-09-15T00:44:48Z

deploy/crds/enterprise.splunk.com_clustermasters_crd.yaml

  versions:
  - additionalPrinterColumns:
-    - description: Status of cluster master
+    - description: Status of cluster manager


Seems like this is a missing change on Develop. I can see the same on my local build.

* move m4 test to integration to clear smoke run (#487) * Feature circleci migration (#490) * Migration of Unit Test and Smoke Test pipelines from CircleCi to Github Actions (#441) * Update cron schedule * Fix a bug where standalone with replicas>1 won't come up (#489) * Added int test workflow and nightly workflows. (#493) * Modify monitoring console selection name to avoid eks cluster creation failure (#494) * Update the name of int test step (#496) * CSPL-1219 (#470) * [CSPL-1283] Fix AWS & minio S3 client code to support App framework on GCS (#498) * Fix minio S3 client code & incorrect minio initContainer ut Add changes to minio client code to handle generic S3 compatable remote stores, namely GCS. * CSPL-1301: Trigger app install for modified app pkgs (#503) * Trigger app install for modified app pkgs While an app package modification does trigger rewritteing the configmap. There are cases where this rewrite will result in the same data section as the previous version of the configmap (for example, when a single app is installed initially then modified.) When this is applied no change is detected and the Pod does not reset or install the new app. By adding a label to the configmap metadata, when an app package change is detected, we can increment this label. This will not affect the data in the configmap since the label is in the metadata section, however the label change will force a new ResourceVersion of the configmap and restart the pod, triggering the modified app install. [UPDATE] Instead of using a label in the ConfigMap metadata, reset the data in the app listing ConfigMap to nothing prior to setting it, forcing a new resourceVerison. * CSPL-1302: Bias-language removal Phase 1 [Comments & Docs] (#497) * Bias-language removal Phase 1 * CSPL-1316 : Avoid app framework flow from re-entrancy (#506) * Automated pre release workflow (#508) * CSPL-1230 Remove need for Secret keys in IAM env (#505) * CSPL-1230 Remove need for Secret keys in IAM env The operator code can be changed to allow no secretRef to be a valid volume config. If no secretRef is configured for a SmartStore or AppFramework volume, then assume the credentials are available on the env itself, possibly through a tool such as kube2iam. * Moved action file to right location (#510) * Update the URL on relese RULE (#512) * CSPL-1339: Fix make_bundle.sh to check for version change (#517) * Splunk Operator 1.0.3 release (#511) * Cspl 1335 official release workflow (#523) * Automated Release Workflow * Added automated workflow to merge develop to master * Fix typo in kubectl create secret command (#524) * Update README.md (#526) * Fix image push jobs from master branch (#530) * Fixing merge issues * CSPL-1298 (#521) * CSPL-1307: Bias-language removal Phase 1 (#504) Implement Github Actions workflow for Bias Language * Update spunk-operator image tag in release directory (#535) * CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. (#519) * CSPL-1327 App install isn't triggered if 1 appsource is empty An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message. * Adding fix for CSPL-1316 for MC * Update test case to accomodate Standalone Updating Phase * Merge issues * Fix Automation test case * Fix automation test * CSPL-1305 - Remove bias language from Paths & URLs (#509) * Bias-Lang Removal P1 - Handling Exceptions Consolidate Paths & URLs from external sources Include exceptions to GithubActions workflow * Fix URLs

* Merge master1.0.1 (#370) 1.0.1 Release * release/1.0.2 (#473) * release/1.0.2 - Addressing doc references to release 1.0.2 * - doc change * - Fixing the olm-catalog CRDs for the versions 1.0.0-RC, 1.0.0, and 1.0.1 (#475) * Fix role yaml * CSPL:1217 Added new cases for app version downgrade (#452) Co-authored-by: Sirish Mohan <68884189+smohan-splunk@users.noreply.github.com> * move m4 test to integration to clear smoke run (#487) * Feature circleci migration (#490) * Migration of Unit Test and Smoke Test pipelines from CircleCi to Github Actions (#441) * Update cron schedule * Fix a bug where standalone with replicas>1 won't come up (#489) * Added int test workflow and nightly workflows. (#493) * Modify monitoring console selection name to avoid eks cluster creation failure (#494) * Update the name of int test step (#496) * CSPL-1219 (#470) * [CSPL-1283] Fix AWS & minio S3 client code to support App framework on GCS (#498) * Fix minio S3 client code & incorrect minio initContainer ut Add changes to minio client code to handle generic S3 compatable remote stores, namely GCS. * CSPL-1301: Trigger app install for modified app pkgs (#503) * Trigger app install for modified app pkgs While an app package modification does trigger rewritteing the configmap. There are cases where this rewrite will result in the same data section as the previous version of the configmap (for example, when a single app is installed initially then modified.) When this is applied no change is detected and the Pod does not reset or install the new app. By adding a label to the configmap metadata, when an app package change is detected, we can increment this label. This will not affect the data in the configmap since the label is in the metadata section, however the label change will force a new ResourceVersion of the configmap and restart the pod, triggering the modified app install. [UPDATE] Instead of using a label in the ConfigMap metadata, reset the data in the app listing ConfigMap to nothing prior to setting it, forcing a new resourceVerison. * CSPL-1302: Bias-language removal Phase 1 [Comments & Docs] (#497) * Bias-language removal Phase 1 * CSPL-1316 : Avoid app framework flow from re-entrancy (#506) * Automated pre release workflow (#508) * CSPL-1230 Remove need for Secret keys in IAM env (#505) * CSPL-1230 Remove need for Secret keys in IAM env The operator code can be changed to allow no secretRef to be a valid volume config. If no secretRef is configured for a SmartStore or AppFramework volume, then assume the credentials are available on the env itself, possibly through a tool such as kube2iam. * Moved action file to right location (#510) * Update the URL on relese RULE (#512) * CSPL-1339: Fix make_bundle.sh to check for version change (#517) * Splunk Operator 1.0.3 release (#511) * Cspl 1335 official release workflow (#523) * Automated Release Workflow * Added automated workflow to merge develop to master * Fix typo in kubectl create secret command (#524) * Update README.md (#526) * Fix image push jobs from master branch (#530) * CSPL-1298 (#521) * CSPL-1307: Bias-language removal Phase 1 (#504) Implement Github Actions workflow for Bias Language * Update spunk-operator image tag in release directory (#535) * CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. (#519) * CSPL-1327 App install isn't triggered if 1 appsource is empty An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message. * CSPL-1305 - Remove bias language from Paths & URLs (#509) * Bias-Lang Removal P1 - Handling Exceptions Consolidate Paths & URLs from external sources Include exceptions to GithubActions workflow * CSPL-1305 - Resolved Nightly builds regression (#547) Fixing Bias Language URLs to use correct tokens * CSPL-1277: Check for status of bundle push on CM (#536) * CSPL-1310 Merge MC feature branch to develop (#548) * CSPL-1306 - Remove bias language from Functions & Local variables (#543) * Bias-Lang P1 - Removal from Functions & Vars Renamed Functions and variables Renamed non-CRD files Added local script for bias language * Generating CRDs after changes * Removing CRD changes for olm legacy versions * Added new image push to int test (#566) * CSPL:1387 Modify app upload logic to selectively upload apps within test case (#557) Co-authored-by: Sirish Mohan <68884189+smohan-splunk@users.noreply.github.com> * CSPL-1379 IDXC fails to scale up when MC CR is deployed with pre-existing IDXC (#562) * IDXC fails to scale up when MC CR is deployed in the namespace with pre existing IDXC * Review comments * CSPL-1438: Add missing mc test develop (#565) * Add Missing MC test in custom resource test * Add missing MC Test in License Manger * Add missing MC test in secret test cases * Cleanup for MC Missing test * CSPL-1412/CSPL-1413 Break down app framework tests (#567) * CSPL-1412 * Update appframework_test.go * CSPL-1447-updated-version-for-find-replace-action (#576) * Updated go version to 1.17.3 (#581) * Cspl 1456 fix nightly test failures by changing testenv length and cleanup env (#579) * CSPL-1443 increase length of random string in appframework test to avoid reuse of same namespace * CSPL-1443 change cleanup logic to delete env every time unless DEBUG is set to true * disabling failing smoke tests in S1 and C3

github-actions bot requested review from akondur, gaurav-splunk, jambrosiano, jryb, kashok-splunk, mgaldino-splunk, pdhanoya-splunk, sgontla, smohan-splunk, tpereirasplunk and vebken-splunk September 14, 2021 22:34

smohan-splunk reviewed Sep 15, 2021

View reviewed changes

akondur reviewed Sep 15, 2021

View reviewed changes

gaurav-splunk approved these changes Sep 15, 2021

View reviewed changes

sgontla approved these changes Sep 15, 2021

View reviewed changes

mgaldino-splunk mentioned this pull request Sep 15, 2021

Revert CRD description changes for 1.0.3 release #513

Closed

[create-pull-request] automated change

0d6124c

github-actions bot force-pushed the release/1.0.3 branch from f001923 to 0d6124c Compare September 15, 2021 18:33

github-actions bot requested review from akondur, gaurav-splunk, sgontla and smohan-splunk September 15, 2021 18:33

smohan-splunk and others added 2 commits September 22, 2021 14:54

Merge branch 'develop' into release/1.0.3

c43f106

Changelog update.

a7b7d8c

smohan-splunk approved these changes Oct 4, 2021

View reviewed changes

smohan-splunk merged commit 574f227 into develop Oct 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Splunk Operator 1.0.3 release #511

Splunk Operator 1.0.3 release #511

Uh oh!

github-actions bot commented Sep 14, 2021

Uh oh!

smohan-splunk Sep 15, 2021

Uh oh!

akondur left a comment

Uh oh!

akondur Sep 15, 2021

Uh oh!

sgontla Sep 15, 2021

Uh oh!

mgaldino-splunk Sep 15, 2021

Uh oh!

smohan-splunk Sep 15, 2021

Uh oh!

smohan-splunk Sep 15, 2021

Uh oh!

akondur Sep 15, 2021 •

edited

Loading

Uh oh!

gaurav-splunk Sep 15, 2021

Uh oh!

sgontla Sep 15, 2021

Uh oh!

Uh oh!

		@@ -0,0 +1,21 @@
		ab073ce Moved action file to right location (#510)

Splunk Operator 1.0.3 release #511

Splunk Operator 1.0.3 release #511

Uh oh!

Conversation

github-actions bot commented Sep 14, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akondur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akondur Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akondur Sep 15, 2021 •

edited

Loading