CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. #519

jryb · 2021-09-22T21:30:54Z

Problem

Apps defined in any defined appSources fail to install when one of the appSources is empty.

Solution

An empty appSource is not necessarily an error. Treat it as a no-op and throw a log message.

Testing

Verify the issue using an empty appSource.

apiVersion: enterprise.splunk.com/v2
kind: Standalone
metadata:
  name: s-af-aws
  finalizers:
  - enterprise.splunk.com/delete-pvc
spec:
  replicas: 1
  appRepo:
    appsRepoPollIntervalSeconds: 60
    volumes:
      - name: volume_app_repo1
        path: my-bucket/apps
        endpoint: https://generic-endpoint
        secretRef: my-secret
        storageType: s3
        provider: aws
    appSources:
      - name: empty
        location: empty_dir/
        volumeName: volume_app_repo1
        scope: local
      - name: admin
        location: admin-apps/
        volumeName: volume_app_repo1
        scope: local
      - name: default
        location: default-test/
        volumeName: volume_app_repo1
        scope: local

Operator logs:

{"level":"info","ts":1632341576.0336561,"logger":"splunk.enterprise.GetRemoteStorageClient","msg":"Creating the client","name":"s-af-aws","namespace":"default","volume":"volume_app_repo1","bucket":"my-bucket","bucket path":"apps/admin-apps/"}
{"level":"info","ts":1632341576.0337934,"logger":"splunk.client.InitAWSClientSession","msg":"AWS Client Session initialization successful.","region":"us-west-2","TLS Version":"TLS 1.2"}
{"level":"info","ts":1632341576.0338306,"logger":"splunk.client.GetAppsList","msg":"Getting Apps list","AWS S3 Bucket":"my-bucket"}
{"level":"info","ts":1632341576.0751379,"logger":"splunk.enterprise.GetRemoteStorageClient","msg":"Creating the client","name":"s-af-aws","namespace":"default","volume":"volume_app_repo1","bucket":"my-bucket","bucket path":"apps/default-test/"}
{"level":"info","ts":1632341576.0752254,"logger":"splunk.client.InitAWSClientSession","msg":"AWS Client Session initialization successful.","region":"us-west-2","TLS Version":"TLS 1.2"}
{"level":"info","ts":1632341576.0752347,"logger":"splunk.client.GetAppsList","msg":"Getting Apps list","AWS S3 Bucket":"my-bucket"}
{"level":"error","ts":1632341576.1195133,"logger":"splunk.enterprise.initAndCheckAppInfoStatus","msg":"Unable to get apps list, will retry in next reconcile...","name":"s-af-aws","namespace":"default","error":"Unable to get apps list from remote storage list for all the apps","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\tsplunk-operator/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/splunk/splunk-operator/pkg/splunk/enterprise.initAndCheckAppInfoStatus\n\tsplunk-operator/pkg/splunk/enterprise/util.go:989\ngithub.com/splunk/splunk-operator/pkg/splunk/enterprise.ApplyStandalone\n\tsplunk-operator/pkg/splunk/enterprise/standalone.go:76\ngithub.com/splunk/splunk-operator/pkg/controller.StandaloneController.Reconcile\n\tsplunk-operator/pkg/controller/add_standalone.go:59\ngithub.com/splunk/splunk-operator/pkg/splunk/controller.splunkReconciler.Reconcile\n\tsplunk-operator/pkg/splunk/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsplunk-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:256\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsplunk-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\tsplunk-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\tsplunk-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\tsplunk-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\tsplunk-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\tsplunk-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:90"}

From standalone we see apps are downloaded but nothing installed:

[splunk@splunk-s-af-aws-standalone-0 splunk]$ ls -Rl /init-apps/
/init-apps/:
total 0
drwxr-sr-x 2 splunk splunk 54 Sep 22 20:13 admin
drwxr-sr-x 2 splunk splunk 77 Sep 22 20:13 default
drwxr-sr-x 2 splunk splunk  6 Sep 22 20:13 empty

/init-apps/admin:
total 8
-rw-r--r-- 1 splunk splunk 1159 Jun 28 18:24 application1.tgz
-rw-r--r-- 1 splunk splunk 1167 Jun 15 07:00 application3.tgz

/init-apps/default:
total 19404
-rw-r--r-- 1 splunk splunk     1154 Jun 28 18:15 application4.tgz
-rw-r--r-- 1 splunk splunk 19865458 Jun 28 18:18 splunk-machine-learning-toolkit_521.tgz

/init-apps/empty:
total 0
[splunk@splunk-s-af-aws-standalone-0 splunk]$ export SPLUNK_ADMIN_PW=$(cat /mnt/splunk-secrets/password); bin/splunk display app -auth admin:$SPLUNK_ADMIN_PW
alert_logevent                 CONFIGURED          ENABLED             INVISIBLE           
alert_webhook                  CONFIGURED          ENABLED             INVISIBLE           
appsbrowser                    CONFIGURED          ENABLED             INVISIBLE           
introspection_generator_addon  CONFIGURED          ENABLED             INVISIBLE           
journald_input                 UNCONFIGURED        ENABLED             INVISIBLE           
launcher                       CONFIGURED          ENABLED             VISIBLE             
learned                        UNCONFIGURED        ENABLED             INVISIBLE           
legacy                         UNCONFIGURED        DISABLED            INVISIBLE           
python_upgrade_readiness_app   UNCONFIGURED        ENABLED             VISIBLE             
sample_app                     UNCONFIGURED        DISABLED            INVISIBLE           
search                         CONFIGURED          ENABLED             VISIBLE             
splunk-dashboard-studio        CONFIGURED          ENABLED             VISIBLE             
splunk_archiver                CONFIGURED          ENABLED             INVISIBLE           
splunk_enterprise_on_docker    CONFIGURED          ENABLED             INVISIBLE           
splunk_essentials_8_2          CONFIGURED          ENABLED             VISIBLE             
splunk_gdi                     UNCONFIGURED        ENABLED             INVISIBLE           
splunk_httpinput               UNCONFIGURED        ENABLED             INVISIBLE           
splunk_instrumentation         UNCONFIGURED        ENABLED             VISIBLE             
splunk_internal_metrics        UNCONFIGURED        ENABLED             INVISIBLE           
splunk_metrics_workspace       UNCONFIGURED        ENABLED             VISIBLE             
splunk_monitoring_console      UNCONFIGURED        ENABLED             VISIBLE             
splunk_rapid_diag              UNCONFIGURED        ENABLED             VISIBLE             
splunk_secure_gateway          UNCONFIGURED        ENABLED             VISIBLE             
SplunkForwarder                UNCONFIGURED        DISABLED            INVISIBLE           
SplunkLightForwarder           UNCONFIGURED        DISABLED            INVISIBLE

Validate fix allowing empty appSources:

Operator logs:

{"level":"info","ts":1632344519.4163465,"logger":"splunk.enterprise.ValidateAppFrameworkSpec","msg":"App framework configuration is valid"}
{"level":"info","ts":1632344519.4163713,"logger":"splunk.enterprise.HasAppRepoCheckTimerExpired","msg":"App repo polling interval timer has expired","LastAppInfoCheckTime":"0","current epoch time":"1632344519"}
{"level":"info","ts":1632344519.4163775,"logger":"splunk.enterprise.initAndCheckAppInfoStatus","msg":"Checking status of apps on remote storage...","name":"s-af-aws","namespace":"default"}
{"level":"info","ts":1632344519.416385,"logger":"splunk.enterprise.GetAppListFromS3Bucket","msg":"Getting the list of apps from remote storage...","name":"s-af-aws","namespace":"default"}
{"level":"info","ts":1632344519.4199648,"logger":"splunk.enterprise.GetRemoteStorageClient","msg":"Creating the client","name":"s-af-aws","namespace":"default","volume":"volume_app_repo1","bucket":"my-bucket","bucket path":"apps/empty_dir/"}
{"level":"info","ts":1632344519.4201217,"logger":"splunk.client.InitAWSClientSession","msg":"AWS Client Session initialization successful.","region":"us-west-2","TLS Version":"TLS 1.2"}
{"level":"info","ts":1632344519.420136,"logger":"splunk.client.GetAppsList","msg":"Getting Apps list","AWS S3 Bucket":"my-bucket"}
{"level":"info","ts":1632344519.5071642,"logger":"splunk.client.GetAppsList","msg":"Empty objects list in bucket. No apps to install","bucketName":"my-bucket"}
{"level":"info","ts":1632344519.5137684,"logger":"splunk.enterprise.GetRemoteStorageClient","msg":"Creating the client","name":"s-af-aws","namespace":"default","volume":"volume_app_repo1","bucket":"my-bucket","bucket path":"apps/admin-apps/"}
{"level":"info","ts":1632344519.5138931,"logger":"splunk.client.InitAWSClientSession","msg":"AWS Client Session initialization successful.","region":"us-west-2","TLS Version":"TLS 1.2"}
{"level":"info","ts":1632344519.5139046,"logger":"splunk.client.GetAppsList","msg":"Getting Apps list","AWS S3 Bucket":"my-bucket"}
{"level":"info","ts":1632344519.5427518,"logger":"splunk.enterprise.GetRemoteStorageClient","msg":"Creating the client","name":"s-af-aws","namespace":"default","volume":"volume_app_repo1","bucket":"my-bucket","bucket path":"apps/default-test/"}
{"level":"info","ts":1632344519.542925,"logger":"splunk.client.InitAWSClientSession","msg":"AWS Client Session initialization successful.","region":"us-west-2","TLS Version":"TLS 1.2"}
{"level":"info","ts":1632344519.5429375,"logger":"splunk.client.GetAppsList","msg":"Getting Apps list","AWS S3 Bucket":"my-bucket"}
{"level":"info","ts":1632344519.5731559,"logger":"splunk.enterprise.initAndCheckAppInfoStatus","msg":"Apps List retrieved from remote storage","name":"s-af-aws","namespace":"default","App Source":"empty","Content":null}
{"level":"info","ts":1632344519.5732002,"logger":"splunk.enterprise.initAndCheckAppInfoStatus","msg":"Apps List retrieved from remote storage","name":"s-af-aws","namespace":"default","App Source":"admin","Content":[{"Etag":"\"c753c78e80b05cc48596b9e79dd4e0e3\"","Key":"apps/admin-apps/application1.tgz","LastModified":"2021-06-28T18:24:57Z","Size":1159,"StorageClass":"STANDARD"},{"Etag":"\"628f3bb977a1efa325d3c83186f55b59\"","Key":"apps/admin-apps/application3.tgz","LastModified":"2021-06-15T07:00:43Z","Size":1167,"StorageClass":"STANDARD"}]}
{"level":"info","ts":1632344519.5732126,"logger":"splunk.enterprise.initAndCheckAppInfoStatus","msg":"Apps List retrieved from remote storage","name":"s-af-aws","namespace":"default","App Source":"default","Content":[{"Etag":"\"36ba50bcfe974906257ddfb977bf72f9\"","Key":"apps/default-test/application4.tgz","LastModified":"2021-06-28T18:15:30Z","Size":1154,"StorageClass":"STANDARD"},{"Etag":"\"00315a3365cd94e0508baae2a6c0f95a-2\"","Key":"apps/default-test/splunk-machine-learning-toolkit_521.tgz","LastModified":"2021-06-28T18:18:30Z","Size":19865458,"StorageClass":"STANDARD"}]}
{"level":"info","ts":1632344519.573232,"logger":"splunk.enterprise.handleAppRepoChanges","msg":"received App listing","kind":"Standalone","name":"s-af-aws","namespace":"default","for App sources":3}

From standalone showing apps downloaded and installed:

[splunk@splunk-s-af-aws-standalone-0 splunk]$ ls -Rl /init-apps/
/init-apps/:
total 0
drwxr-sr-x 2 splunk splunk 54 Sep 22 21:02 admin
drwxr-sr-x 2 splunk splunk 77 Sep 22 21:02 default
drwxr-sr-x 2 splunk splunk  6 Sep 22 21:02 empty

/init-apps/admin:
total 8
-rw-r--r-- 1 splunk splunk 1159 Jun 28 18:24 application1.tgz
-rw-r--r-- 1 splunk splunk 1167 Jun 15 07:00 application3.tgz

/init-apps/default:
total 19404
-rw-r--r-- 1 splunk splunk     1154 Jun 28 18:15 application4.tgz
-rw-r--r-- 1 splunk splunk 19865458 Jun 28 18:18 splunk-machine-learning-toolkit_521.tgz

/init-apps/empty:
total 0
[splunk@splunk-s-af-aws-standalone-0 splunk]$ export SPLUNK_ADMIN_PW=$(cat /mnt/splunk-secrets/password); bin/splunk display app -auth admin:$SPLUNK_ADMIN_PW
alert_logevent                 CONFIGURED          ENABLED             INVISIBLE           
alert_webhook                  CONFIGURED          ENABLED             INVISIBLE           
application1                   UNCONFIGURED        ENABLED             VISIBLE             
application3                   UNCONFIGURED        ENABLED             VISIBLE             
application4                   UNCONFIGURED        ENABLED             VISIBLE             
appsbrowser                    CONFIGURED          ENABLED             INVISIBLE           
introspection_generator_addon  CONFIGURED          ENABLED             INVISIBLE           
journald_input                 UNCONFIGURED        ENABLED             INVISIBLE           
launcher                       CONFIGURED          ENABLED             VISIBLE             
learned                        UNCONFIGURED        ENABLED             INVISIBLE           
legacy                         UNCONFIGURED        DISABLED            INVISIBLE           
python_upgrade_readiness_app   UNCONFIGURED        ENABLED             VISIBLE             
sample_app                     UNCONFIGURED        DISABLED            INVISIBLE           
search                         CONFIGURED          ENABLED             VISIBLE             
splunk-dashboard-studio        CONFIGURED          ENABLED             VISIBLE             
splunk_archiver                CONFIGURED          ENABLED             INVISIBLE           
splunk_enterprise_on_docker    CONFIGURED          ENABLED             INVISIBLE           
splunk_essentials_8_2          CONFIGURED          ENABLED             VISIBLE             
splunk_gdi                     UNCONFIGURED        ENABLED             INVISIBLE           
splunk_httpinput               UNCONFIGURED        ENABLED             INVISIBLE           
splunk_instrumentation         UNCONFIGURED        ENABLED             VISIBLE             
splunk_internal_metrics        UNCONFIGURED        ENABLED             INVISIBLE           
splunk_metrics_workspace       UNCONFIGURED        ENABLED             VISIBLE             
Splunk_ML_Toolkit              UNCONFIGURED        ENABLED             VISIBLE             
splunk_monitoring_console      UNCONFIGURED        ENABLED             VISIBLE             
splunk_rapid_diag              UNCONFIGURED        ENABLED             VISIBLE             
splunk_secure_gateway          UNCONFIGURED        ENABLED             VISIBLE             
SplunkForwarder                UNCONFIGURED        DISABLED            INVISIBLE           
SplunkLightForwarder           UNCONFIGURED        DISABLED            INVISIBLE

Validate that standalone comes up with only empty appSource.

NAME                                  READY   STATUS    RESTARTS   AGE
splunk-default-monitoring-console-0   0/1     Running   0          58s
splunk-operator-65c846679d-h6ktc      1/1     Running   0          7m47s
splunk-s-af-aws-standalone-0          1/1     Running   0          2m5s

An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message.

sgontla · 2021-09-22T22:17:45Z

Nit: As this API is independent of the CRs, I guess, covering the test as part of awss3client_test.go is enough.

jryb · 2021-09-22T22:32:38Z

Nit: As this API is independent of the CRs, I guess, covering the test as part of awss3client_test.go is enough.

True, you're probably right that the per CR tests duplicate the coverage of the awss3client tests. Though they do make sure that the app framework code works as expected in a CR level functional way. Also I hate to take out tests in case there is additional coverage I'm not thinking of. So I would lean toward leaving them in unless there's consensus to take them out.

* move m4 test to integration to clear smoke run (#487) * Feature circleci migration (#490) * Migration of Unit Test and Smoke Test pipelines from CircleCi to Github Actions (#441) * Update cron schedule * Fix a bug where standalone with replicas>1 won't come up (#489) * Added int test workflow and nightly workflows. (#493) * Modify monitoring console selection name to avoid eks cluster creation failure (#494) * Update the name of int test step (#496) * CSPL-1219 (#470) * [CSPL-1283] Fix AWS & minio S3 client code to support App framework on GCS (#498) * Fix minio S3 client code & incorrect minio initContainer ut Add changes to minio client code to handle generic S3 compatable remote stores, namely GCS. * CSPL-1301: Trigger app install for modified app pkgs (#503) * Trigger app install for modified app pkgs While an app package modification does trigger rewritteing the configmap. There are cases where this rewrite will result in the same data section as the previous version of the configmap (for example, when a single app is installed initially then modified.) When this is applied no change is detected and the Pod does not reset or install the new app. By adding a label to the configmap metadata, when an app package change is detected, we can increment this label. This will not affect the data in the configmap since the label is in the metadata section, however the label change will force a new ResourceVersion of the configmap and restart the pod, triggering the modified app install. [UPDATE] Instead of using a label in the ConfigMap metadata, reset the data in the app listing ConfigMap to nothing prior to setting it, forcing a new resourceVerison. * CSPL-1302: Bias-language removal Phase 1 [Comments & Docs] (#497) * Bias-language removal Phase 1 * CSPL-1316 : Avoid app framework flow from re-entrancy (#506) * Automated pre release workflow (#508) * CSPL-1230 Remove need for Secret keys in IAM env (#505) * CSPL-1230 Remove need for Secret keys in IAM env The operator code can be changed to allow no secretRef to be a valid volume config. If no secretRef is configured for a SmartStore or AppFramework volume, then assume the credentials are available on the env itself, possibly through a tool such as kube2iam. * Moved action file to right location (#510) * Update the URL on relese RULE (#512) * CSPL-1339: Fix make_bundle.sh to check for version change (#517) * Splunk Operator 1.0.3 release (#511) * Cspl 1335 official release workflow (#523) * Automated Release Workflow * Added automated workflow to merge develop to master * Fix typo in kubectl create secret command (#524) * Update README.md (#526) * Fix image push jobs from master branch (#530) * Fixing merge issues * CSPL-1298 (#521) * CSPL-1307: Bias-language removal Phase 1 (#504) Implement Github Actions workflow for Bias Language * Update spunk-operator image tag in release directory (#535) * CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. (#519) * CSPL-1327 App install isn't triggered if 1 appsource is empty An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message. * Adding fix for CSPL-1316 for MC * Update test case to accomodate Standalone Updating Phase * Merge issues * Fix Automation test case * Fix automation test * CSPL-1305 - Remove bias language from Paths & URLs (#509) * Bias-Lang Removal P1 - Handling Exceptions Consolidate Paths & URLs from external sources Include exceptions to GithubActions workflow * Fix URLs

* Merge master1.0.1 (#370) 1.0.1 Release * release/1.0.2 (#473) * release/1.0.2 - Addressing doc references to release 1.0.2 * - doc change * - Fixing the olm-catalog CRDs for the versions 1.0.0-RC, 1.0.0, and 1.0.1 (#475) * Fix role yaml * CSPL:1217 Added new cases for app version downgrade (#452) Co-authored-by: Sirish Mohan <68884189+smohan-splunk@users.noreply.github.com> * move m4 test to integration to clear smoke run (#487) * Feature circleci migration (#490) * Migration of Unit Test and Smoke Test pipelines from CircleCi to Github Actions (#441) * Update cron schedule * Fix a bug where standalone with replicas>1 won't come up (#489) * Added int test workflow and nightly workflows. (#493) * Modify monitoring console selection name to avoid eks cluster creation failure (#494) * Update the name of int test step (#496) * CSPL-1219 (#470) * [CSPL-1283] Fix AWS & minio S3 client code to support App framework on GCS (#498) * Fix minio S3 client code & incorrect minio initContainer ut Add changes to minio client code to handle generic S3 compatable remote stores, namely GCS. * CSPL-1301: Trigger app install for modified app pkgs (#503) * Trigger app install for modified app pkgs While an app package modification does trigger rewritteing the configmap. There are cases where this rewrite will result in the same data section as the previous version of the configmap (for example, when a single app is installed initially then modified.) When this is applied no change is detected and the Pod does not reset or install the new app. By adding a label to the configmap metadata, when an app package change is detected, we can increment this label. This will not affect the data in the configmap since the label is in the metadata section, however the label change will force a new ResourceVersion of the configmap and restart the pod, triggering the modified app install. [UPDATE] Instead of using a label in the ConfigMap metadata, reset the data in the app listing ConfigMap to nothing prior to setting it, forcing a new resourceVerison. * CSPL-1302: Bias-language removal Phase 1 [Comments & Docs] (#497) * Bias-language removal Phase 1 * CSPL-1316 : Avoid app framework flow from re-entrancy (#506) * Automated pre release workflow (#508) * CSPL-1230 Remove need for Secret keys in IAM env (#505) * CSPL-1230 Remove need for Secret keys in IAM env The operator code can be changed to allow no secretRef to be a valid volume config. If no secretRef is configured for a SmartStore or AppFramework volume, then assume the credentials are available on the env itself, possibly through a tool such as kube2iam. * Moved action file to right location (#510) * Update the URL on relese RULE (#512) * CSPL-1339: Fix make_bundle.sh to check for version change (#517) * Splunk Operator 1.0.3 release (#511) * Cspl 1335 official release workflow (#523) * Automated Release Workflow * Added automated workflow to merge develop to master * Fix typo in kubectl create secret command (#524) * Update README.md (#526) * Fix image push jobs from master branch (#530) * CSPL-1298 (#521) * CSPL-1307: Bias-language removal Phase 1 (#504) Implement Github Actions workflow for Bias Language * Update spunk-operator image tag in release directory (#535) * CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. (#519) * CSPL-1327 App install isn't triggered if 1 appsource is empty An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message. * CSPL-1305 - Remove bias language from Paths & URLs (#509) * Bias-Lang Removal P1 - Handling Exceptions Consolidate Paths & URLs from external sources Include exceptions to GithubActions workflow * CSPL-1305 - Resolved Nightly builds regression (#547) Fixing Bias Language URLs to use correct tokens * CSPL-1277: Check for status of bundle push on CM (#536) * CSPL-1310 Merge MC feature branch to develop (#548) * CSPL-1306 - Remove bias language from Functions & Local variables (#543) * Bias-Lang P1 - Removal from Functions & Vars Renamed Functions and variables Renamed non-CRD files Added local script for bias language * Generating CRDs after changes * Removing CRD changes for olm legacy versions * Added new image push to int test (#566) * CSPL:1387 Modify app upload logic to selectively upload apps within test case (#557) Co-authored-by: Sirish Mohan <68884189+smohan-splunk@users.noreply.github.com> * CSPL-1379 IDXC fails to scale up when MC CR is deployed with pre-existing IDXC (#562) * IDXC fails to scale up when MC CR is deployed in the namespace with pre existing IDXC * Review comments * CSPL-1438: Add missing mc test develop (#565) * Add Missing MC test in custom resource test * Add missing MC Test in License Manger * Add missing MC test in secret test cases * Cleanup for MC Missing test * CSPL-1412/CSPL-1413 Break down app framework tests (#567) * CSPL-1412 * Update appframework_test.go * CSPL-1447-updated-version-for-find-replace-action (#576) * Updated go version to 1.17.3 (#581) * Cspl 1456 fix nightly test failures by changing testenv length and cleanup env (#579) * CSPL-1443 increase length of random string in appframework test to avoid reuse of same namespace * CSPL-1443 change cleanup logic to delete env every time unless DEBUG is set to true * disabling failing smoke tests in S1 and C3

jryb added 2 commits September 22, 2021 14:27

CSPL-1327 App install isn't triggered if 1 appsource is empty

769c303

An empty `appSource` is not necessarily an error. Treat it as a no-op and throw a log message.

Fix tests to allow empty appSources

8c796f0

jryb requested review from gaurav-splunk, smohan-splunk, sgontla and vebken-splunk September 22, 2021 21:56

sgontla approved these changes Sep 22, 2021

View reviewed changes

gaurav-splunk approved these changes Sep 22, 2021

View reviewed changes

smohan-splunk approved these changes Oct 6, 2021

View reviewed changes

smohan-splunk added 2 commits October 6, 2021 10:58

Merge branch 'develop' into bugfix/CSPL-1327_empty_appsource

314d66e

Merge branch 'develop' into bugfix/CSPL-1327_empty_appsource

23c5a49

smohan-splunk merged commit a7beb0f into develop Oct 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. #519

CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. #519

Uh oh!

jryb commented Sep 22, 2021 •

edited

Loading

Uh oh!

sgontla commented Sep 22, 2021

Uh oh!

jryb commented Sep 22, 2021

Uh oh!

Uh oh!

CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. #519

CSPL-1327 App framework: App installation isn't triggered if 1 appsource is empty. #519

Uh oh!

Conversation

jryb commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Uh oh!

sgontla commented Sep 22, 2021

Uh oh!

jryb commented Sep 22, 2021

Uh oh!

Uh oh!

jryb commented Sep 22, 2021 •

edited

Loading