Verify the target is given correctly to method invocations #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1651 +/- ##
=============================================
+ Coverage 0 78.08% +78.08%
- Complexity 0 4043 +4043
=============================================
Files 0 427 +427
Lines 0 13075 +13075
Branches 0 1689 +1689
=============================================
+ Hits 0 10210 +10210
- Misses 0 2233 +2233
- Partials 0 632 +632
☔ View full report in Codecov by Sentry. |
Since Spock 2.0 the lifecycle for simple features was broken. The initializer execution was not within the feature execution. This is fixed with this change, that uses the dynamic test executor to execute the iteration delegate instead of mixing the lifecycles.
Vampire
force-pushed
the
verify-target-in-method-invocation
branch
from
eb774c9
to
aa16fb0
Compare
|
Replace by #1680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1650