fix: handle panics #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
approved these changes
Oct 22, 2025
Comment on lines
+127
to
+130
| private reloadInstance(error:unknown) { | ||
| logger.error('Failure calling into wasm:', error); | ||
| try { | ||
| this.bufferedLogs.push(this.delegate.flushLogs()); |
There was a problem hiding this comment.
What happens with unrecoverable errors? I am thinking if the wasm doesn't restart and we keep pushing data to the bufferedLogs we might have a memory leak, perhaps cap the bufferedLogs
There was a problem hiding this comment.
The only thing that can produce logs is a successful resolve. And what's happening here is that we try once to extract logs from a broken instance before we throw it away. I don't think it's a problem from a memory leak perspective, i.e. this can't cause logs to grow faster than what successful operation does.
andreas-karlsson
force-pushed
the
handle-panics
branch
from
6bc951b to
c82a2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.