Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caduri/may 2021/update to latest #2

Merged
merged 1,457 commits into from
May 24, 2021
Merged

Caduri/may 2021/update to latest #2

merged 1,457 commits into from
May 24, 2021

Conversation

caduri
Copy link
Collaborator

@caduri caduri commented May 20, 2021

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.


Helpful Tips

Add screenshots and annotations

Add a gif to show an action

GIFs are great to show an action, however they sometimes move too fast.
One way to improve them is to capture 3 pieces of content:

  • screenshot before an action
  • screenshot after the action
  • gif of the action
  • You can edit a gif using https://ezgif.com/

Put a border around a screenshot/gif

Add a border to help improve the readability.

<kbd>![](https://www.spinnaker.io/assets/images/spinnaker-logo-inline.svg)</kbd>

Add expandable sections

Add expandable sections to hide away large code blocks/images or reduce the motion of a gifs
const example = 'spinnaker spinnaker SPINNAKER';

caseyhebebrand and others added 30 commits February 22, 2021 20:04
5a9768b chore(lint): Update import statement ordering
cca56ea chore(lint): Sort import statements
5a9768b chore(lint): Update import statement ordering
cca56ea chore(lint): Sort import statements
feat(titus/serverGroup): Enable ipv6 in test environment
* fix(core): avoid fetching security groups twice

* fix(core): avoid fetching security groups twice - better version

Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>

Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
…er#8944)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fix(amazon): Instance DNS hrefs when Instance Port is not defined
…he cell takes up the available width (spinnaker#8942)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
IDEs run eslint eagerly and seeing prettier lint errors pop-up aggressively results
in a poor dev experience. So removing the prettier linter here.
…ker#8943)

1) When doing local development, it's annoying that webpack-dev-server doesn't reload if there are any eslint errors. 2) Marking this rule as a warning seems reasonable anyway

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Upgrading to the latest version and removing unnecessary packages.
…enforced during compilation) (spinnaker#8949)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…cations

feat(core/notifications): Save app notifications when modal is submitted
* feat(core): initiate search on enter. If an exact app match was found, open the app directly

* feat(core): highlight matching app

* Update app/scripts/modules/core/src/search/global/GlobalSearch.tsx

* Update app/scripts/modules/core/src/search/global/GlobalSearchResults.tsx

Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…warning

fix(amazon): Update logic for subnet warning
fix(aws): Simplify security group extraction
c344366 Merge branch 'master' into aws-secGroups
bd2f60f fix(aws): Simplify security group extraction
a9be538 fix(amazon): Update logic for subnet warning
bbee13d fix(amazon/loadBalancer): Fix text for cross-zone load balancing
fd516ba fix(amazon): Instance DNS hrefs when Instance Port is not defined
eb38aba feat(core): global search box - search on enter (spinnaker#8948)
14ec907 Merge branch 'master' into save-app-notifications
fa96f32 chore(md): enable strict null check on the editor level (it won't be enforced during compilation) (spinnaker#8949)
f53787e fix(core/presentation): Apply `flex: 1` to responsive table cell so the cell takes up the available width (spinnaker#8942)
6b1eb67 feat(core/notifications): Save app notifications when modal is submitted
3adbdf3 fix(core): avoid fetching security groups twice (spinnaker#8938)
a784e1e Merge branch 'master' into titus-ipv6-enable
3397619 feat(titus/serverGroup): Enable ipv6 in test environment
a784e1e Merge branch 'master' into titus-ipv6-enable
3397619 feat(titus/serverGroup): Enable ipv6 in test environment
Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
…to viewState (spinnaker#8957)

* fix(amazon/serverGroup): Move spelLoadBalancers and spelTargetGroups to viewState (do not send these values to the server)

* test: fix tests for spelLoadBalancers
vigneshm and others added 29 commits April 21, 2021 09:29
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
)

* chore(cloudfoundry): Implements map load balancer (cloudfoundry route) modal.

* chore(cloudfoundry): Removes unneeded functions.

* Update app/scripts/modules/cloudfoundry/src/loadBalancer/configure/CloudFoundryMapLoadBalancerModal.tsx

Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…pinnaker#9150)

(cherry picked from commit 8aeeaf7)

Co-authored-by: Fernando Freire <fernando.freire@armory.io>
…pinnaker#9161)

Co-authored-by: Zach Smith <33258732+zachsmith1@users.noreply.github.com>
(cherry picked from commit 936c3a1)

Co-authored-by: Raúl Vázquez <raul.vazquez@armory.io>
…aker#9164)

* fix(core): fix state update for pipeline tags

* fix(core): make metadata page content overridable

(cherry picked from commit 31e8303)

Co-authored-by: Fernando Freire <fernando.freire@armory.io>
spinnaker#9153) (spinnaker#9165)

* fix(deck): Attempt to fix `Cannot read property 'length' of undefined`

* Update app/scripts/modules/core/src/filterModel/FilterTags.tsx

Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com>

Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com>
Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 94bfcf4)

Co-authored-by: Raúl Vázquez <raul.vazquez@armory.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@caduri caduri merged commit 3f7db85 into poc May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.