forked from spinnaker/deck
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caduri/may 2021/update to latest #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(titus/serverGroup): Enable ipv6 in test environment
* fix(core): avoid fetching security groups twice * fix(core): avoid fetching security groups twice - better version Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com> Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
…er#8944) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fix(amazon): Instance DNS hrefs when Instance Port is not defined
…he cell takes up the available width (spinnaker#8942) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
IDEs run eslint eagerly and seeing prettier lint errors pop-up aggressively results in a poor dev experience. So removing the prettier linter here.
…ker#8943) 1) When doing local development, it's annoying that webpack-dev-server doesn't reload if there are any eslint errors. 2) Marking this rule as a warning seems reasonable anyway Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Upgrading to the latest version and removing unnecessary packages.
…enforced during compilation) (spinnaker#8949) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…cations feat(core/notifications): Save app notifications when modal is submitted
* feat(core): initiate search on enter. If an exact app match was found, open the app directly * feat(core): highlight matching app * Update app/scripts/modules/core/src/search/global/GlobalSearch.tsx * Update app/scripts/modules/core/src/search/global/GlobalSearchResults.tsx Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…warning fix(amazon): Update logic for subnet warning
fix(aws): Simplify security group extraction
c344366 Merge branch 'master' into aws-secGroups bd2f60f fix(aws): Simplify security group extraction a9be538 fix(amazon): Update logic for subnet warning bbee13d fix(amazon/loadBalancer): Fix text for cross-zone load balancing fd516ba fix(amazon): Instance DNS hrefs when Instance Port is not defined
eb38aba feat(core): global search box - search on enter (spinnaker#8948) 14ec907 Merge branch 'master' into save-app-notifications fa96f32 chore(md): enable strict null check on the editor level (it won't be enforced during compilation) (spinnaker#8949) f53787e fix(core/presentation): Apply `flex: 1` to responsive table cell so the cell takes up the available width (spinnaker#8942) 6b1eb67 feat(core/notifications): Save app notifications when modal is submitted 3adbdf3 fix(core): avoid fetching security groups twice (spinnaker#8938) a784e1e Merge branch 'master' into titus-ipv6-enable 3397619 feat(titus/serverGroup): Enable ipv6 in test environment
Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
…to viewState (spinnaker#8957) * fix(amazon/serverGroup): Move spelLoadBalancers and spelTargetGroups to viewState (do not send these values to the server) * test: fix tests for spelLoadBalancers
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
0014556 Remove webpack modules + webpack consolidation (spinnaker#9097)
) * chore(cloudfoundry): Implements map load balancer (cloudfoundry route) modal. * chore(cloudfoundry): Removes unneeded functions. * Update app/scripts/modules/cloudfoundry/src/loadBalancer/configure/CloudFoundryMapLoadBalancerModal.tsx Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…pinnaker#9150) (cherry picked from commit 8aeeaf7) Co-authored-by: Fernando Freire <fernando.freire@armory.io>
…pinnaker#9161) Co-authored-by: Zach Smith <33258732+zachsmith1@users.noreply.github.com> (cherry picked from commit 936c3a1) Co-authored-by: Raúl Vázquez <raul.vazquez@armory.io>
…aker#9164) * fix(core): fix state update for pipeline tags * fix(core): make metadata page content overridable (cherry picked from commit 31e8303) Co-authored-by: Fernando Freire <fernando.freire@armory.io>
spinnaker#9153) (spinnaker#9165) * fix(deck): Attempt to fix `Cannot read property 'length' of undefined` * Update app/scripts/modules/core/src/filterModel/FilterTags.tsx Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com> Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com> Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 94bfcf4) Co-authored-by: Raúl Vázquez <raul.vazquez@armory.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
Helpful Tips
Add screenshots and annotations
Add a gif to show an action
GIFs are great to show an action, however they sometimes move too fast.
One way to improve them is to capture 3 pieces of content:
Put a border around a screenshot/gif
Add a border to help improve the readability.
Add expandable sections
Add expandable sections to hide away large code blocks/images or reduce the motion of a gifs