Skip to content

SPR-11627 fix #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SPR-11627 fix #622

wants to merge 2 commits into from

Conversation

asarkar
Copy link

@asarkar asarkar commented Apr 3, 2014

GroovyDynamicElementReader tries to read a Groovy script as XML and fails - SPR-11627

@asarkar
Copy link
Author

asarkar commented Apr 3, 2014

I'm not sure of a contributor agreement need to be signed for this small change but if you accept the pull and need me to sign one, I can. Just let me know.

@dsyer
Copy link
Member

dsyer commented Apr 3, 2014

There's a link to the contributor's agreement in the README. Thanks.

@sbrannen
Copy link
Member

sbrannen commented Apr 3, 2014

I don't think it's a good idea to set the xmlReader.validationMode to false.

Keep in mind that the xmlReader is used to read XML. So you don't want to disable validation for XML configuration files as an unintentional side effect.

That's why I recommended using the GroovyBeanDefinitionReader(BeanDefinitionRegistry) constructor.

@asarkar asarkar closed this Apr 3, 2014
@asarkar
Copy link
Author

asarkar commented Apr 3, 2014

Got it, closed this request, opened a new one #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants