SPR-11627 fix #630
Closed
SPR-11627 fix #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2014 00:11
Closed
|
Did you fill in the contributor's agreement yet? |
|
I didn't because the README said that it's not required for minor changes. Since you asked, I'm going to do it anyway. |
|
Thanks. The README actually says "please fill out the CA before your first change however trivial". If that's not clear enough we should change it. |
|
My bad, I misunderstood it. The language is perfectly fine. I submitted the ICA, confirmation # 77520140404030015. |
|
Cheers. It was merged :) |
gigfork
pushed a commit
to boostrack/spring-boot
that referenced
this pull request
Apr 21, 2014
Since it is not parsing XML it makes no sense to be validating and it would cause exceptions when importing "namespace" features. This brings the Boot usage of the bean builder inline with that in Spring Core. Fixes spring-projectsgh-630
mdeinum
pushed a commit
to mdeinum/spring-boot
that referenced
this pull request
Jun 6, 2014
Since it is not parsing XML it makes no sense to be validating and it would cause exceptions when importing "namespace" features. This brings the Boot usage of the bean builder inline with that in Spring Core. Fixes spring-projectsgh-630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroovyDynamicElementReader tries to read a Groovy script as XML and fails - SPR-11627