Skip to content

DATACOUCH-588 - Implement pageable and realign with other spring-data projects #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mikereiche
Copy link
Collaborator

This is my second pull-request for this. I've removed the unrelated bug fixes.

This implements pageable for non-reactive queries and
realigns reactive queries with other spring-data projects
to facilitate the implementaion of pageable (done) and other
types of queries such as projection and distinct (not yet
done)

The isDelete() etc. methods in CouchbaseQueryMethod are called by methods of the same names in AbstractCouchbaseQuery.

The ReactivePagedExecution is commented out - they don't seem like the best implementations. Mark suggested following the pattern in Mongo and Cassandra.

Edit: I just noticed I haven't updated the authors and copyright notices as required.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@tchlyah
Copy link
Contributor

tchlyah commented Sep 21, 2020

Hello, do you have any ETA for merging this issue ? The issues fixed in this PR are blocking the whole Spring Boot 2.3 upgrade for jhipster. See jhipster/generator-jhipster#12300

@mikereiche
Copy link
Collaborator Author

mikereiche commented Sep 21, 2020

Hello, do you have any ETA for merging this issue ? The issues fixed in this PR are blocking the whole Spring Boot 2.3 upgrade for jhipster. See jhipster/generator-jhipster#12300

@tchlyah I'm looking at pulling the scanConsistency fix into its own branch so it can be committed sooner. Hopefully this week. The next

@mikereiche mikereiche force-pushed the datacouch_588_pageable_and_realign branch 3 times, most recently from cc9f6b4 to 7f0ee59 Compare September 22, 2020 01:33
@tchlyah
Copy link
Contributor

tchlyah commented Oct 8, 2020

Hello @mikereiche, can you please resolve the conflicts? We would like to see that merged ASAP! Thanks a lot

@mikereiche mikereiche force-pushed the datacouch_588_pageable_and_realign branch from 7f0ee59 to 9535649 Compare October 19, 2020 19:51
This implements pageable for non-reactive queries and
realigns reactive queries with other spring-data projects
to facilitate the implementaion of pageable (done) and other
types of queries such as projection and distinct (not yet
done)
@mikereiche mikereiche force-pushed the datacouch_588_pageable_and_realign branch 5 times, most recently from 4a82819 to a418e2e Compare October 20, 2020 23:32
@daschl daschl requested a review from mp911de October 21, 2020 18:16
@mp911de
Copy link
Member

mp911de commented Oct 22, 2020

Please let's move this PR into the next version (4.2) as right now, were post RC2 for 4.1 and the amount of changes bears quite some risk. Typically, a release should be feature complete before entering the RC phase and after the last release candidate, we allow only documentation changes, bugfixes, polishing, test refactorings, and such.

This implements pageable for non-reactive queries and
realigns reactive queries with other spring-data projects
to facilitate the implementaion of pageable (done) and other
types of queries such as projection and distinct (not yet
done)
…base into datacouch_588_pageable_and_realign
@mikereiche mikereiche force-pushed the datacouch_588_pageable_and_realign branch from a418e2e to f6288f1 Compare November 3, 2020 17:53
@mikereiche mikereiche marked this pull request as draft November 3, 2020 19:44
@mikereiche mikereiche assigned daschl and unassigned daschl Nov 3, 2020
@mikereiche mikereiche requested a review from daschl November 3, 2020 19:45
@mikereiche mikereiche closed this Dec 9, 2020
@mikereiche
Copy link
Collaborator Author

superseded

@mikereiche mikereiche deleted the datacouch_588_pageable_and_realign branch January 15, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants