Unexpected token in HQL Update @Query when base package name starts with an SQL Keyword [DATAJPA-659]

[spring-projects-issues]

Chinmay Shah opened DATAJPA-659 and commented

Here's my query which is failing validation -

@Modifying
@Query("update ENTITYCLASSXXXXXXXXXXXXXXXXXXXXXXXX smpb set smpb.active = :active where smpb.sx1 = :sx1 and smpb.sx2 = :sx2")
void updateXXX(@Param("sx1") String sx1, @Param("sx2") Integer sx2, @Param("active") Boolean active);

Here's the reason:

16 Jan 2015 21:09:57,824 ERROR: org.hibernate.hql.internal.ast.ErrorCounter - line 1:8: unexpected token: in
16 Jan 2015 21:09:57,825 ERROR: org.hibernate.hql.internal.ast.ErrorCounter - line 1:8: unexpected token: in
line 1:8: unexpected token: in
	at org.hibernate.hql.internal.antlr.HqlBaseParser.updateStatement(HqlBaseParser.java:239)
	at org.hibernate.hql.internal.antlr.HqlBaseParser.statement(HqlBaseParser.java:169)

---

Attachments:

• DummyInfo.java (525 bytes)
• DummyInfoRepository.java (497 bytes)
• log.txt (1.95 kB)
• set_log.txt (18.05 kB)

[spring-projects-issues]

Oliver Drotbohm commented

I am not quite sure what you think is the Spring Data JPA bug here. The exception states that there's an unexpected token in the query you defined. Seems like it's related to the entity type declaration (column 8) but that's nothing we actually can do something about

[spring-projects-issues]

Chinmay Shah commented

That was my initial thought as well. I reviewed my entities, couldn't find anything amiss. The project has extensively used spring data.

Anyways, i just created a new project with just 1 entity, and declared the interface with an HQL update query. I see the same validation errors.

I have attached the relevant files for your reference. Also attached is a log.

This validation error is not encountered if my base package name does not start with in.*
If i change it to say org., or ina. i do not see these errors.

Edit: If the base package starts with SQL key words like where., in., or., set., etc. you will encounter these.

Example log for where.*

17 Jan 2015 11:03:30,972 ERROR: org.hibernate.hql.internal.ast.ErrorCounter - line 1:8: unexpected token: where
17 Jan 2015 11:03:30,974 ERROR: org.hibernate.hql.internal.ast.ErrorCounter - line 1:8: unexpected token: where
line 1:8: unexpected token: where
at org.hibernate.hql.internal.antlr.HqlBaseParser.updateStatement(HqlBaseParser.java:239)

Just updated the title, this is limited to "starting with" SQL words in the base package name. If the package name contains an "in" or any other, we are fine.

[spring-projects-issues]

Jens Schauder commented

I still don't see how this is a Spring Data problem

[arn-varma]

Hi, what is the solution for this, I am also getting same issue. I can't keep the package name for the entity starting in.**

[schauder]

It seems you have three options:

1. Open a ticket with Hibernate, since for all what we can tell it is a problem with their parser
2. Rename your entity to avoid the issue
3. Convince us that it is a Spring Data JPA issue and not a Hibernate issue by providing a reproducer that demonstrates that the problem exists with Spring Data JPA, but not when executing the query with the EntityManager directly.