Polishing.

Reformat code. Add since tag.

See #995
Original pull request: #1014.

Author: mp911de

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DefaultSelectBuilder.java

@@ -37,13 +37,13 @@
 class DefaultSelectBuilder implements SelectBuilder, SelectAndFrom, SelectFromAndJoin, SelectWhereAndOr {
 
 	private boolean distinct = false;
-	private List<Expression> selectList = new ArrayList<>();
-	private List<TableLike> from = new ArrayList<>();
+	private final List<Expression> selectList = new ArrayList<>();
+	private final List<TableLike> from = new ArrayList<>();
 	private long limit = -1;
 	private long offset = -1;
-	private List<Join> joins = new ArrayList<>();
+	private final List<Join> joins = new ArrayList<>();
 	private @Nullable Condition where;
-	private List<OrderByField> orderBy = new ArrayList<>();
+	private final List<OrderByField> orderBy = new ArrayList<>();
 	private @Nullable LockMode lockMode;
 
 	/*

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/SelectBuilder.java

@@ -503,13 +503,13 @@ interface SelectOn {
 		SelectOnConditionComparison on(Expression column);
 
 		/**
-		 * Declare a join condition in one step.
-		 *
-		 * Using conditions allows more flexibility in comparison to  {@link #on(Expression)} which only allows for equality comparisons chained together with `AND`.
+		 * Declare a join {@link Condition condition} in one step. Using conditions allows more flexibility in comparison to
+		 * {@link #on(Expression)} which only allows for equality comparisons chained together with {@code AND}.
 		 *
 		 * @param condition must not be {@literal null}.
 		 * @return {@code this} builder.
 		 * @see Conditions
+		 * @since 2.3
 		 */
 		SelectFromAndJoinCondition on(Condition condition);
 	}

spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/SelectRendererUnitTests.java

@@ -156,8 +156,8 @@ void shouldRenderSimpleJoinWithAnd() {
 				+ "AND employee.tenant = department.tenant");
 	}
 
-	@Test // GH-995
-	public void shouldRenderArbitraryJoinCondition() {
+	@Test // #995
+	void shouldRenderArbitraryJoinCondition() {
 
 		Table employee = SQL.table("employee");
 		Table department = SQL.table("department");
@@ -166,11 +166,9 @@ public void shouldRenderArbitraryJoinCondition() {
 				.select(employee.column("id"), department.column("name")) //
 				.from(employee) //
 				.join(department) //
-				.on(
-						Conditions.isEqual( employee.column("department_id"),department.column("id")) //
-								.or( //
-						Conditions.isNotEqual( employee.column("tenant"),department.column("tenant")) //
-				)) //
+				.on(Conditions.isEqual(employee.column("department_id"), department.column("id")) //
+						.or(Conditions.isNotEqual(employee.column("tenant"), department.column("tenant")) //
+						))
 				.build();
 
 		assertThat(SqlRenderer.toString(select)).isEqualTo("SELECT employee.id, department.name FROM employee " //
@@ -424,16 +422,12 @@ void shouldRenderWithRenderContext() {
 				"SELECT COUNT(\"my_table\".*) AS counter, \"my_table\".\"reserved_keyword\" FROM \"my_table\" JOIN \"join_table\" ON \"my_table\".source = \"join_table\".target");
 	}
 
-
 	@Test // GH-1034
 	void simpleComparisonWithStringArguments() {
 
 		Table table_user = SQL.table("User");
-		Select select = StatementBuilder
-				.select(table_user.column("name"),table_user.column("age"))
-				.from(table_user)
-				.where(Comparison.create("age",">",20))
-				.build();
+		Select select = StatementBuilder.select(table_user.column("name"), table_user.column("age")).from(table_user)
+				.where(Comparison.create("age", ">", 20)).build();
 
 		final String rendered = SqlRenderer.toString(select);
 		assertThat(rendered).isEqualTo("SELECT User.name, User.age FROM User WHERE age > 20");
@@ -443,11 +437,8 @@ void simpleComparisonWithStringArguments() {
 	void simpleComparison() {
 
 		Table table_user = SQL.table("User");
-		Select select = StatementBuilder
-				.select(table_user.column("name"),table_user.column("age"))
-				.from(table_user)
-				.where(Comparison.create(table_user.column("age"),">",SQL.literalOf(20)))
-				.build();
+		Select select = StatementBuilder.select(table_user.column("name"), table_user.column("age")).from(table_user)
+				.where(Comparison.create(table_user.column("age"), ">", SQL.literalOf(20))).build();
 
 		final String rendered = SqlRenderer.toString(select);
 		assertThat(rendered).isEqualTo("SELECT User.name, User.age FROM User WHERE User.age > 20");