BeanFactoryAnnotationUtils,qualifiedBeanOfType, Inefficient use of keySet iterator. [SPR-12356]

[spring-projects-issues]

Min Ho Pak opened SPR-12356 and commented

BeanFactoryAnnotationUtils,qualifiedBeanOfType method use KeySet Iterator.

It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

pull request:
#667

---

Affects: 4.1.1

Issue Links:

• MessageHeaderAccessor copyHeaders... tuning [SPR-12431] #17037 MessageHeaderAccessor copyHeaders... tuning
• org.springframework.ui.ModelMap.mergeAttributes(Map) makes inefficient use of keySet iterator [SPR-12363] #16968 org.springframework.ui.ModelMap.mergeAttributes(Map) makes inefficient use of keySet iterator

Referenced from: pull request #667, and commits 2e5d752

[spring-projects-issues]

Stéphane Nicoll commented

Thanks for the PR. You get a point that in that particular case this is more efficient, especially because we are building a map ourselves and we can guarantee its nature.