Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build to Gradle 3.0 [SPR-14569] #19138

Closed
spring-projects-issues opened this issue Aug 8, 2016 · 13 comments
Closed

Upgrade build to Gradle 3.0 [SPR-14569] #19138

spring-projects-issues opened this issue Aug 8, 2016 · 13 comments
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 8, 2016

Juergen Hoeller opened SPR-14569 and commented

Gradle 3.0 is in RC2 now and very likely generally available in time for our 5.0 M2. Let's upgrade to it for a smoother JDK 9 experience, literally just requiring a JAVA_HOME change then.


Issue Links:

  • #17778 Upgrade core framework build to JDK 11 ("is depended on by")
  • #19211 Out-of-the-box build compatibility with JDK 9 build 136 ("is depended on by")
  • #19157 Upgrade build to Gradle 3.0 ("is duplicated by")
  • #17928 Compatibility with merged JDK 9 mainline
  • #18934 Upgrade build to Gradle 2.14.1
  • #19139 Upgrade 4.3.x build to Gradle 2.14.x
  • #19472 Upgrade build to Gradle 3.2.1

Referenced from: commits c399b4b, e6353f0, c64cdcc, 669fd80, 9629afb

0 votes, 5 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 8, 2016

Juergen Hoeller commented

Gradle 3.0 RC2 works for me so far after a local upgrade.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 15, 2016

Sam Brannen commented

Juergen Hoeller, sorry about raising #19157 as a duplicate. I somehow overlooked this issue when searching.

In any case, Gradle 3.0 is out, and I've already upgraded the build locally (with a clean test run).

So, do you want me to push my changes to master, or are you in the process of performing the upgrade yourself?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 15, 2016

Juergen Hoeller commented

No worries, I'm on Gradle 3.0 RC2 still. Please push the upgrade to GA and I'll grab it right away.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 15, 2016

Sam Brannen commented

Done! ;-)

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 18, 2016

Stéphane Nicoll commented

This broke our build because test reports aren't in the same location anymore. It seems that Bamboo is not able to change the location on a branch-by-branch basis so we should find a way to put test reports at the same location as Gradle 2.x does.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 21, 2016

Sam Brannen commented

Stéphane Nicoll,

You should be able to set the destination in which Gradle generates XML test reports as follows, where my-custom-location is whatever path you desire under the current project's build directory.

test {
	reports.junitXml.destination = file("$buildDir/my-custom-location")
}

Does that work for you?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 22, 2016

Sam Brannen commented

Re-resolving this issue as Complete since the build is now passing again with the latest changes to the location of generated JUnit XML files.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Stéphane Nicoll commented

The SonarQube build is broken as well

java.lang.NoSuchMethodError: org.gradle.internal.jvm.Jvm.getRuntimeJar()Ljava/io/File;
        at org.sonarqube.gradle.SonarQubePlugin.getLibraries(SonarQubePlugin.java:362)
        at org.sonarqube.gradle.SonarQubePlugin.configureSourceDirsAndJavaClasspath(SonarQubePlugin.java:308)
        at org.sonarqube.gradle.SonarQubePlugin.access$200(SonarQubePlugin.java:63)
        at org.sonarqube.gradle.SonarQubePlugin$9.execute(SonarQubePlugin.java:229)
        at org.sonarqube.gradle.SonarQubePlugin$9.execute(SonarQubePlugin.java:226)
        at org.gradle.internal.Actions$FilteredAction.execute(Actions.java:205)
        at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:117)
        at org.gradle.api.internal.DefaultDomainObjectCollection.withType(DefaultDomainObjectCollection.java:127)

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Brian Clozel commented

We need to wait for the next release of the SonarQube Gradle plugin - see SONARGRADL-16.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Sam Brannen commented

Brian Clozel, thanks for pointing us to the SonarQube issue. (y)

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 29, 2016

Dejan Stojadinović commented

I'm already using sonarqube gradle plugin version 2.1-rc1 for my projects (in parallel with gradle 3.0): https://plugins.gradle.org/plugin/org.sonarqube/2.1-rc1; I guess that SonarSource will release version 2.1 in a few days.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 30, 2016

Stéphane Nicoll commented

Our build has been upgrade to the 2.1-rc1 version of the plugin that works with Gradle 3.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 30, 2016

Sam Brannen commented

(y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants