Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron Expression validation [SPR-14933] #19500

Closed
spring-projects-issues opened this issue Nov 22, 2016 · 2 comments
Closed

Cron Expression validation [SPR-14933] #19500

spring-projects-issues opened this issue Nov 22, 2016 · 2 comments
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 22, 2016

Arcadius Ahouansou opened SPR-14933 and commented

With Spring, the

CronSequenceGenerator.parse()

method does not seem robust enough....

It silently takes expressions such as

0 0/05 * * * *SUN
0 0/05 * * * SUN*
0 0/05 *ANYTHING_HERE * * *

as valid cron expressions.

Moreover,

0 0/05 * * * MON-SUN

throws

java.lang.IllegalArgumentException: Overflow in day for expression "0 0/05 * * * MON-SUN"

Ideally, we want to have a proper and robust cron expression validator.

Note that this issue is related to #13621


Affects: 4.3.4

Attachments:

Issue Links:

  • #13621 Cron expression with fixed weekday and fixed date may or may not lead to IllegalStateException (runaway search for next trigger)
  • #20163 Cron expression validation method in CronSequenceGenerator improved
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 22, 2016

Arcadius Ahouansou commented

Unit tests

@prasadram
Copy link

@prasadram prasadram commented Mar 28, 2020

Hi Arcadius Ahouansou,

i would like to work on this issue, please let me know whether i can pick this issue or not ?

@poutsma poutsma self-assigned this Jul 24, 2020
@poutsma poutsma closed this in 762cf0f Aug 4, 2020
@jhoeller jhoeller modified the milestones: 5.x Backlog, 5.3 M2 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.