Cron expression validation method in CronSequenceGenerator improved [SPR-15604]

[spring-projects-issues]

Ruslan Sibgatullin opened SPR-15604 and commented

This method validated only fields length of the given expression, not the validity of cron expression. It seems logical that the method with name 'isValidExpression' would validate cron as well.
Plus, possible NPE fixed.

---

Affects: 4.3.8

Issue Links:

• NullPointerException if cron expression is null [SPR-15683] #20242 NullPointerException if cron expression is null ("is duplicated by")
• Cron Expression validation [SPR-14933] #19500 Cron Expression validation

Referenced from: pull request #1442, and commits 674e232, 5f4d1a4

[spring-projects-issues]

Juergen Hoeller commented

Thanks for raising this! I've implemented this in a slightly different fashion, doing some basic validation upfront and then using a custom CronSequenceGenerator created via a new constructor... so that we reduce the need to catch IllegalArgumentException.