Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebFilter ordering in WebHttpHandlerBuilder only works on instances [SPR-15074] #19640

Closed
spring-projects-issues opened this issue Dec 30, 2016 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 30, 2016

Stéphane Nicoll opened SPR-15074 and commented

in WebHttpHandlerBuilder, WebFilter instances are ordered using AnnotationAwareOrderComparator. That will only work if the ordering is set on the class itself.

The following will be ignored

@Configuration
public class MyConfig {
  
   @Bean @Order(42)
   public WebFilter myFilter() { ... }

}

There is an ignored test in the spring-boot-web-reactive project that reproduces this behaviour


Affects: 5.0 M4

Issue Links:

Referenced from: commits b609f3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants