Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockSessionCookieConfig#maxAge defaults to 0 instead of -1 [SPR-15142] #19708

Closed
spring-projects-issues opened this issue Jan 15, 2017 · 2 comments
Assignees
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 15, 2017

Vedran Pavic opened SPR-15142 and commented

MockSessionCookieConfig#maxAge defaults to 0 which causes cookies to be deleted instead of written during tests. Rather than 0, default value for maxAge should be -1 as one would expect from a typical container.


Affects: 4.3.5

Issue Links:

Referenced from: commits 83beb9d, d1c0ea7

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 15, 2017

Vedran Pavic commented

Created a PR: #1298

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 16, 2017

Sam Brannen commented

Good catch.

Thanks for bringing this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants