Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAP HANA to common JPA database platforms [SPR-16460] #21005

Closed
spring-projects-issues opened this issue Feb 2, 2018 · 6 comments
Closed

Add SAP HANA to common JPA database platforms [SPR-16460] #21005

spring-projects-issues opened this issue Feb 2, 2018 · 6 comments
Assignees
Labels
in: data type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Feb 2, 2018

Jonathan Bregler opened SPR-16460 and commented

Currently it's not possible to specify HANA as the database using the

spring.jpa.database

property.


Affects: 5.0.3

Issue Links:

  • #18833 Add database product name for SAP HANA
  • #21013 HibernateJpaDialect: Default to MySQL55Dialect based on InnoDB
  • #21101 Consistent incrementer arrangement for PostgreSQL, DB2 and SAP HANA

Referenced from: pull request #1661, and commits 504e276

1 votes, 3 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 19, 2018

Jonathan Bregler commented

Hi Jürgen,

do you have an estimate when my pull request could get merged? I'm planning on making more contributions to other Spring projects, but those contributions depend on this change.

Thanks,
Jonathan

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 23, 2018

joerg.hohwiller@googlemail.com commented

PR seems to be #1661

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 23, 2018

Juergen Hoeller commented

This looks like a great fit for our 5.1 timeline. We'll start 5.1 preparations in about a month, right after the 5.0.5 release.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 6, 2018

Juergen Hoeller commented

I've narrowed this JIRA ticket to the primary purpose of the report: SAP HANA as a common database platform in Spring's JpaVendorAdapter mechanism, with a wider overhaul planned for 5.1 there.

As for the two side improvements of the pull request - namely detecting all database product name variants and introducing a HanaSequenceMaxValueIncrementer -, I'm in the process of dealing with them as part of #21101 for 5.0.5 and 4.3.15 already.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 5, 2018

Juergen Hoeller commented

I've rolled this into master for 5.1 RC1 now, as a custom commit that completes the scope of your original submission.

A note on Hibernate: Is HANAColumnStoreDialect indeed the ideal default there? Wouldn't HANARowStoreDialect be a better match for common ORM access patterns?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 7, 2018

Jonathan Bregler commented

Thanks for merging the change.

HANAColumnStoreDialect is indeed the correct default. The SAP HANA column store is generally preferred over the row store as it offers more features as well as other advantages. The HANARowStoreDialect should only be used in special cases if there is a concrete application requirement that can't be fulfilled by the HANAColumnStoreDialect.
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants