Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HibernateJpaDialect: Default to MySQL55Dialect based on InnoDB [SPR-16468] #21013

Closed
spring-projects-issues opened this issue Feb 5, 2018 · 3 comments
Labels
status: duplicate

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Feb 5, 2018

Mike Eltsufin opened SPR-16468 and commented

MySQL5Dialect set currently as default is based on the MyISAM storage engine, which is not recommended.
MySQL 5.5 has been out since 2010. So, it's pretty safe to go with it as the default dialect.

Related to: spring-attic/spring-cloud-gcp#392.

See PR: #1660


Affects: 5.0.3

Reference URL: https://stackoverflow.com/questions/1459265/hibernate-create-mysql-innodb-tables-instead-of-myisam

Issue Links:

  • #21005 Add SAP HANA to common JPA database platforms

Referenced from: pull request #1660

1 votes, 4 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 5, 2018

Juergen Hoeller commented

I'm not concerned about a MySQL 5.5 default from a version availability perspective. However, a change from MyISAM to InnoDB could be perceived as too radical. In practice, I expect most people to explicitly declare their dialect already since they won't be happy with the default... but there might still be some innocent usage of the MyISAM default in some places.

Nevertheless: Stéphane Nicoll, Phil Webb, if you feel that this is worth doing for Boot 2.0 GA, I'm happy to give it a try in 5.0.4 (and ask people affected to explicitly declare the old dialect if they care).

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 5, 2018

Juergen Hoeller commented

It looks like MySQL55Dialect is only available in Hibernate ORM 5.2.9 and later. Since we support any Hibernate 5.x version at this point (even the default 5.0.x and 5.1.x versions included in JBoss EAP 7 and older WildFly releases), I'm afraid we can only raise the default dialect level in a Spring Framework generation that raises the Hibernate ORM baseline.

Along the same lines, we should also upgrade to Informix10Dialect at the same time.

@snicoll
Copy link
Member

@snicoll snicoll commented Mar 8, 2019

Duplicate of #22326

@snicoll snicoll marked this as a duplicate of #22326 Mar 8, 2019
@snicoll snicoll closed this as completed Mar 8, 2019
@snicoll snicoll added status: duplicate and removed in: data type: enhancement labels Mar 8, 2019
@snicoll snicoll removed this from the 5.x Backlog milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate
Projects
None yet
Development

No branches or pull requests

2 participants