Remove use of Boolean constructors #1281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codacy warns us that there are several references to Boolean constructors in the tests. Direct usage of the Boolean constructor is discouraged and even deprecated in Java 9 [1]. Boolean constructor use can easily be replaced with the constant instances. This commit contains the following changes: - replace references to Boolean constructors with boolean constants in JSP tag tests - update the copyright year where necessary - BooleanComparatorTests is intentionally left unchanged as it should also work with the non-constant instances correctly [1] http://download.java.net/java/jdk9/docs/api/java/lang/Boolean.html#Boolean-boolean- Issue: SPR-15076
snicoll
added a commit
that referenced
this pull request
Jan 4, 2017
* pr/1281: Remove use of Boolean constructors
|
Fixed in 19e77cd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codacy warns us that there are several references to Boolean
constructors in the tests. Direct usage of the Boolean constructor is
discouraged and even deprecated in Java 9 [1]. Boolean constructor use
can easily be replaced with the constant instances.
This commit contains the following changes:
JSP tag tests
also work with the non-constant instances correctly
[1] http://download.java.net/java/jdk9/docs/api/java/lang/Boolean.html#Boolean-boolean-
Issue: SPR-15076