SPR-16590: getParameterValues would work incorrectly #1740
Conversation
|
@jasonjoo2010 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@jasonjoo2010 Thank you for signing the Contributor License Agreement! |
jasonjoo2010
changed the title
| @@ -87,14 +89,28 @@ public String getParameter(String name) { | |||
| } | |||
| return super.getParameter(name); | |||
| } | |||
|
|
|||
| public String[] mergeTwoParameterValues(String[] val1, String[] val2) { | |||
There was a problem hiding this comment.
Need not be a public method.
| return val1; | ||
| } | ||
| //merge them together before return | ||
| String[] merged = Arrays.copyOf(val2, val1.length + val2.length); |
There was a problem hiding this comment.
It's counter-intuitive for a method that merges to arrays, two put the second one first.
There was a problem hiding this comment.
So i fix them and add getParameterValues test in CommonsMultipartResolverTests.
But i used forced pushing to avoid unnecessary commits and found i cannot reopen this.
Should i open another PR?
There was a problem hiding this comment.
Force push is fine. Just keep the branch updated, no need to re-create the PR.
Affected method:
DefaultMultipartHttpServletRequest::getParameterValues
DefaultMultipartHttpServletRequest::getParameterMap
getParameterValues is used to return multi values of a same key in request, including query string, post contents.
And DefaultMultipartHttpServletRequest would be used instead of default servlet wrapper when using "multipart/form-data" post method to realize including vars in multipart body. And there is a problem in its getter in dealing values of same keys. It will not merge them to values in query string.
It can be reproduced by following steps:
You will get a parameter map like:
And you will get:
Let's sit down to discuss whether fix it?