AnnotationAwareOrderComparator now exposes INSTANCE constant. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The INSTANCE constant you could refer to on AnnotationAwareOrderComparator actually referred to the constant declared in OrderAwareComparator. Thus AnnotationAwareOrderComparator.INSTANCE did not actually return an AnnotationAwareOrderComparator but an OrderAwareComparator only. This commit introduces a dedicated constant on AnnotationAwareOrderComparator to avoid this glitch. Issue: SPR-10038
cbeams
added a commit
that referenced
this pull request
Nov 26, 2012
# By Oliver Gierke * SPR-10038: Introduce AnnotationAwareOrderComparator#INSTANCE
ghost
assigned
|
Thanks, Ollie. Just in time for RC2 as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The INSTANCE constant you could refer to on
AnnotationAwareOrderComparator actually referred to the constant declared
in OrderAwareComparator. Thus AnnotationAwareOrderComparator.INSTANCE
did not actually return an AnnotationAwareOrderComparator but an
OrderAwareComparator only. This commit introduces a dedicated constant
on AnnotationAwareOrderComparator to avoid this glitch.
Issue: SPR-10038