Fix OkHttp3ClientHttpRequestFactory shutdown flow #23628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix now triggers closing and removing all idle connections inside connection pool used by OkHttpClient.
spring-projects-issues
added
the
status: waiting-for-triage
|
Anyone? Is there a chance to get this merged? |
rstoyanchev
added
in: web
rstoyanchev
removed
the
status: waiting-for-triage
pull bot
pushed a commit
to scope-demo/spring-framework
that referenced
this pull request
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix now triggers closing and removing all idle connections inside the connection pool used by OkHttpClient.
The problem was discovered after switching from Java 8 to Java 11 and consequently to HTTP/2.
The recommendation from OkHttp developer was a proper shutdown:
square/okhttp#5446
Problem can be reproduced with this snippet of code:
alexey-anufriev/okhttpclient-shutdown-problem@29abbda#diff-70a5fa50b52c03a98de3a02c98de30a1