Skip to content

Simplify ConstructorResolver: do not sort intermediate array #23969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2019
Merged

Simplify ConstructorResolver: do not sort intermediate array #23969

merged 1 commit into from
Nov 11, 2019

Conversation

stsypanov
Copy link
Contributor

There's no need to create an intermediate array of Method candidates just to sort it. Intead we can directly sort existing ArrayList which costs us the same as there's array under the hood.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 11, 2019
@jhoeller jhoeller self-assigned this Nov 11, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 11, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 11, 2019
@jhoeller jhoeller merged commit 92efe95 into spring-projects:master Nov 11, 2019
@stsypanov stsypanov deleted the simplify-const-resolver branch November 11, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@stsypanov @jhoeller @spring-projects-issues