Skip to content

Conversation

larsgrefer
Copy link
Contributor

Don't access the defaultLocale field directly, but use the getter method, so it can be overridden.

The sibling class org.springframework.web.servlet.i18n.AcceptHeaderLocaleResolver already uses the getter.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 6, 2020
@jhoeller jhoeller changed the title Honor overriden AccepptHeaderLocaleContextResolver.getDefaultLocale() Honor overridden AccepptHeaderLocaleContextResolver.getDefaultLocale() Apr 7, 2020
@jhoeller jhoeller self-assigned this Apr 7, 2020
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 7, 2020
@jhoeller jhoeller added this to the 5.2.6 milestone Apr 7, 2020
@jhoeller jhoeller changed the title Honor overridden AccepptHeaderLocaleContextResolver.getDefaultLocale() Honor overridden AcceptHeaderLocaleContextResolver.getDefaultLocale() Apr 7, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Apr 7, 2020
@jhoeller jhoeller merged commit 8682a5d into spring-projects:master Apr 9, 2020
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants