Skip to content

Simplify substring() usage in MimeTypeUtils #24933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2020
Merged

Simplify substring() usage in MimeTypeUtils #24933

merged 3 commits into from
Apr 19, 2020

Conversation

mikaelparsekyan
Copy link
Contributor

Removed redundant if-constructions and unnecessary variable declaration.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 19, 2020
sbrannen
sbrannen requested changes Apr 19, 2020
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I have requested that you revert a few of the changes.

Once you've done that, we'll be able to merge this.

@sbrannen sbrannen changed the title Removed redundant code Simplify substring() usage in MimeTypeUtils Apr 19, 2020
@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 19, 2020
@mikaelparsekyan
Copy link
Contributor Author

I did the changes.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 19, 2020
@sbrannen sbrannen self-assigned this Apr 19, 2020
@sbrannen sbrannen added this to the 5.2.6 milestone Apr 19, 2020
@sbrannen sbrannen merged commit d6c9c7d into spring-projects:master Apr 19, 2020
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

@mikaelparsekyan
Copy link
Contributor Author

I am glad I helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen Awaiting requested review from sbrannen

Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: feedback-provided Feedback has been provided type: task A general task
Projects
None yet
Milestone
5.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelparsekyan @sbrannen @spring-projects-issues