Add missing @PathVariable declarations in examples in webmvc.adoc #25006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We say " For example, given URL "/spring-web-3.0.5 .jar", the following method extracts the name, version, and file extension:" So added PathVariable name to complete the code.
minor fix for kotlin
|
@swapy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@swapy Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: documentation
sbrannen
changed the title
sbrannen
changed the title
|
Thanks for the PR. We'll get this merged soon. |
sbrannen
reviewed
May 4, 2020
| @@ -1634,15 +1634,15 @@ extracts the name, version, and file extension: | |||
| .Java | |||
| ---- | |||
| @GetMapping("/{name:[a-z-]+}-{version:\\d\\.\\d\\.\\d}{ext:\\.[a-z]+}") | |||
| public void handle(@PathVariable String version, @PathVariable String ext) { | |||
| public void handle(@PathVariable name, @PathVariable String version, @PathVariable String ext) { | |||
There was a problem hiding this comment.
FYI: you accidentally deleted the String type declaration for the name parameter.
But don't worry about it: I've fixed it locally prior to merging.
Suggested change
| public void handle(@PathVariable name, @PathVariable String version, @PathVariable String ext) { | |
| public void handle(@PathVariable String name, @PathVariable String version, @PathVariable String ext) { |
There was a problem hiding this comment.
Sorry for that and thanks a lot. I will be careful next time.
jhoeller
added
the
in: web
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We say
For example, given URL "/spring-web-3.0.5 .jar", the following method extracts the name, version, and file extension:
So added PathVariable name to complete the code.