Skip to content

Conversation

mdeinum
Copy link
Contributor

@mdeinum mdeinum commented Nov 17, 2020

There are more locations which could benefit from not using a
toCharArray on a String, but rather use the charAt method from
the String itself. This to prevent an additional copy of the
char[] being created.

There are more locations which could benefit from not using a
toCharArray on a String, but rather use the charAt method from
the String itself. This to prevent an additional copy of the
char[] being created.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 17, 2020
@mdeinum
Copy link
Contributor Author

mdeinum commented Nov 17, 2020

Additional note, while inspecting the AspectJAdviceParameterNameDiscoverer I noticed that it might be beneficial to extract the isVariableName method from the AbstractAspectJAdvice to a helper/utility class and use that from both classes. They share the same logic to determine if something is a variable name.

@jhoeller jhoeller self-assigned this Nov 17, 2020
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 17, 2020
@jhoeller jhoeller added this to the 5.3.2 milestone Nov 17, 2020
@jhoeller jhoeller merged commit c9b27af into spring-projects:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants