Request streaming for Apache HttpClient #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rstoyanchev Could you take a look at this? |
- Added org.springframework.http.StreamingHttpOutputMessage, which allows for a settable request body (as opposed to an output stream). - Added http.client.HttpComponentsStreamingClientHttpRequest, which implements the above mentioned interface, mapping setBody() to a setEntity() call on the Apache HttpClient HttpEntityEnclosingRequest. - Added a 'bufferRequestBody' property to the HttpComponentsClientHttpRequestFactory. When this property is set to false (default is true), we return a HttpComponentsStreamingClientHttpRequest instead of a (request buffering) HttpComponentsClientHttpRequest. Issue: SPR-10728
|
This is now in master. |
| @Override | ||
| protected OutputStream getBodyInternal(HttpHeaders headers) throws IOException { | ||
| throw new UnsupportedOperationException( | ||
| "getBody not supported when bufferRequestBody is false"); |
There was a problem hiding this comment.
Hi, I was trying to implement a custom patch for this solution on my own. That's when I saw that you guys were already working on this. If you throw an exception when getBody is called, then how will the body be flushed to the stream?
There was a problem hiding this comment.
+1
I've tested FormHttpMessageConverter and it is broken for HttpComponentsClientHttpRequestFactory with setBufferRequestBody set to false
There was a problem hiding this comment.
Could you create an issue on https://jira.spring.io and explain the problem there?
Thanks!
There was a problem hiding this comment.
It's already created
https://jira.spring.io/browse/SPR-11199
This was referenced Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for a settable request body (as opposed to an output stream).
implements the above mentioned interface, mapping setBody() to a
setEntity() call on the Apache HttpClient HttpEntityEnclosingRequest.
HttpComponentsClientHttpRequestFactory. When this property is set to
false (default is true), we return a
HttpComponentsStreamingClientHttpRequest instead of a (request
buffering) HttpComponentsClientHttpRequest.
Issue: SPR-10728