Clean up spring-jdbc tests warnings #518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up compiler warnings in the tests of spring-jdbc. This commit adds type parameters to all the types (mostly `List` and `Map`). In addition it uses Java 5 autoboxing to get rid of all of the following * new Integer * new Long * new Float * new Double * new Boolean * new String This should be unnoticeably faster since interning can be uses for Integer and such. After this commit the only warnings in spring-jdbc left are: * raw type warning in `MapDataSourceLookupTests`, that code would never compile with generics * deprecation warning for `#queryForInt` and `#queryForLong` I did sign the CLA
snicoll
added a commit
to snicoll/spring-framework
that referenced
this pull request
Apr 22, 2014
…ning * spring-jdbc-warning: Clean up spring-jdbc tests warnings
|
Merged, thanks! Please note the copyright should be updated if needed (see code style) and avoid updating the imports statement structure unless you really need to. I've fixed that and squashed my commit into yours. |
|
Ok, I will in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up compiler warnings in the tests of spring-jdbc. This commit
adds type parameters to all the types (mostly
ListandMap). Inaddition it uses Java 5 autoboxing to get rid of all of the following
This should be unnoticeably faster since interning can be uses for
Integer and such.
After this commit the only warnings in spring-jdbc left are:
MapDataSourceLookupTests, that code would nevercompile with generics
#queryForIntand#queryForLongI did sign the CLA