StringUtils.trimAllWhitespace(String str) is slow. #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringUtils.trimAllWhitespace(String str) is slow. Using sb.deleteCharAt(index) is not a good idea, it will call System.arraycopy(value, index+1, value, index, count-index-1); Test: https://gist.github.com/hengyunabc/a4651e90db24cc5ed29a
snicoll
added a commit
that referenced
this pull request
Jun 13, 2014
* pull562: Improve StringUtils#trimAllWhitespace
|
Thanks for the contribution! Looking a bit closer, I slightly change the code to improve it further. This has been merged to master. |
|
I hava updated the test: It seems that myTrimAllWhitespace2 is a better algrithom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringUtils.trimAllWhitespace(String str) is slow.
Using sb.deleteCharAt(index) is not a good idea, it will call
System.arraycopy(value, index+1, value, index, count-index-1);
Test:
https://gist.github.com/hengyunabc/a4651e90db24cc5ed29a
I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.