Conditional Error Message Formatting #797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create error message strings only if an actual error has happened. This seems to be the common pattern in the code base base and saves both CPU and memory. We found only very few places where unconditional error message formatting happens. - fix unconditional error message formatting in AdviceModeImportSelector - fix unconditional error message formatting in AnnotationAttributes - fix unconditional error message formatting in ReadOnlySystemAttributesMap, this also fixes a potential NullPointerException I did sign the CLA. Issue: SPR-13007
sbrannen
added a commit
that referenced
this pull request
May 10, 2015
* SPR-13007: Avoid eager formatting in pre-condition checks
|
This has been merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create error message strings only if an actual error has happened. This
seems to be the common pattern in the code base base and saves both CPU
and memory. We found only very few places where unconditional error
message formatting happens.
AdviceModeImportSelector
ReadOnlySystemAttributesMap, this also fixes a potential
NullPointerException
I did sign the CLA.
Issue: SPR-13007