Skip to content

SPR-13657 Buffered AsyncClientHttpResponse #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jmnarloch
Copy link
Contributor

This pull request relates to #912 in a way that it covers some additional use cases that could be covered through AsyncRestTemplate like for instance request/response logging. To fully facilitate that you would require the responses to be buffered.

Copy link

@Vijendra07Kulhade Vijendra07Kulhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes going in some release? I am looking for the solution for my question http://stackoverflow.com/questions/42309192/how-to-use-bufferingclienthttpresponsewrapper-with-httpcomponentsasyncclienthttp

@Vijendra07Kulhade
Copy link

I tried using these changes with AsyncRestTemplate. BufferingAsyncClientHttpRequestFactory is only implementing AsyncClientHttpRequestFactory and AsyncRestTemplate constructor takes ClientHttpRequestFactory also. It will break during autowiring.

@oalmali
Copy link

oalmali commented Feb 3, 2018

This is really needed why this PR was abandoned? Without this response body could be read only once.

@rstoyanchev
Copy link
Contributor

I'm not sure how this one slipped through but the AsyncRestTemplate is deprecated in 5.0 in favor of WebClient, and we're not planning any more new features in 4.3.x. If you're on 5.0, I would highly recommend using the WebClient instead.

@rstoyanchev rstoyanchev closed this Feb 5, 2018
@pivotal-issuemaster
Copy link

@jmnarloch Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants