#545 - Support for implicitly not required request parameters #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@f-cramer Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@f-cramer Thank you for signing the Contributor License Agreement! |
This was referenced Jun 28, 2021
odrotbohm
pushed a commit
that referenced
this pull request
Jun 28, 2021
Handler method parameters annotated with @RequestParam(defaultValue = …) are implicitly not required and thus should still be advertised in the URI templated generated. Previously it was necessary to explicitly set @RequestParam(required = …) to false. Original pull request: #1511. Related ticket: #331.
odrotbohm
pushed a commit
that referenced
this pull request
Jun 28, 2021
Handler method parameters annotated with @RequestParam(defaultValue = …) are implicitly not required and thus should still be advertised in the URI templated generated. Previously it was necessary to explicitly set @RequestParam(required = …) to false. Original pull request: #1511. Related ticket: #331.
odrotbohm
pushed a commit
that referenced
this pull request
Jun 28, 2021
Handler method parameters annotated with @RequestParam(defaultValue = …) are implicitly not required and thus should still be advertised in the URI templated generated. Previously it was necessary to explicitly set @RequestParam(required = …) to false. Original pull request: #1511. Related ticket: #331.
|
That's in place now and back-ported to the maintenance branches. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
Before this commit parameters annotated with
@RequestParam(defaultValue = "default")where handled differently to parameters annotated with@RequestParam(defaultValue = "default", required = false), although both annotations are semantically identicial.