Add NullaWay to package-info for o.s.i.config package #10208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pay attention how those annotations are converted GH user handles: |
|
Thank you for catching that! Updated the comment. |
It doesn't help any more. I just mean the reasoning behind my preference to use code snippet tools in commit messages as well. |
|
Understood. |
artembilan
requested changes
Jul 17, 2025
...ain/java/org/springframework/integration/config/AbstractSimpleMessageHandlerFactoryBean.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/integration/config/AbstractSimpleMessageHandlerFactoryBean.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/springframework/integration/config/CorrelationStrategyFactoryBean.java
Show resolved
Hide resolved
.../java/org/springframework/integration/config/DefaultConfiguringBeanFactoryPostProcessor.java
Outdated
Show resolved
Hide resolved
...ation-core/src/main/java/org/springframework/integration/config/SpelFunctionFactoryBean.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Jul 18, 2025
...ain/java/org/springframework/integration/config/AbstractSimpleMessageHandlerFactoryBean.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/integration/config/AbstractSimpleMessageHandlerFactoryBean.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/integration/config/AbstractSimpleMessageHandlerFactoryBean.java
Outdated
Show resolved
Hide resolved
artembilan
reviewed
Jul 18, 2025
...re/src/main/java/org/springframework/integration/config/IntegrationManagementConfigurer.java
Outdated
Show resolved
Hide resolved
Add @org.jspecify.annotations.NullAway to package-info.java Apply @nullable, @SuppressWarnings("NullAway.Init) as need. Tweak code as necessary in locations where NullAway can not descern that the null condition is already mitigated
…mpleMessageHandlerFactoryBean Remove commented code in AbstractSimpleMessageHandlerFactoryBean.extractTarget Restructure IntegrationManagementConfigurer.registerComponentGauges so that a NullAway suppresion can be removed from the method related to: spring-projects#10083 rebased
cppwfs
force-pushed
the
apply-NullAway-to-package-o.s.i.config
branch
from
eaa0633 to
d5f97cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@org.jspecify.annotations.NullAwayto package-info.java@Nullable,@SuppressWarnings("NullAway.Init)as need. Tweak code as necessary in locations where NullAway can not discern that the null condition is already mitigated