Apply NullAbility to rsocket module #10303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
artembilan
requested changes
Aug 12, 2025
...ion-rsocket/src/main/java/org/springframework/integration/rsocket/RSocketConnectedEvent.java
Outdated
Show resolved
Hide resolved
...ocket/src/main/java/org/springframework/integration/rsocket/ServerRSocketMessageHandler.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/springframework/integration/rsocket/outbound/RSocketOutboundGateway.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/springframework/integration/rsocket/outbound/RSocketOutboundGateway.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
artembilan
requested changes
Aug 12, 2025
| * @param routeVariables the variables to expand route template. | ||
| */ | ||
| @SuppressWarnings("this-escape") | ||
| public RSocketOutboundGateway(Expression routeExpression, Object @Nullable [] routeVariables) { |
There was a problem hiding this comment.
Please, revise this to be a private ctor.
I don't want to encourage users to follow this pattern.
It is really better to do that how it is explained in JavaDocs: fully via expression.
The expression is going to be evaluated against request message at runtime, and there you can build the route whatever way you need.
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083