GH-10137: Cache session.list result in the AbstractInboundFileSynchronizer
#10344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
changed the title
session.list result in the `AbstractInboundFileSync…session.list result in the AbstractInboundFileSynchronizer
cppwfs
requested changes
Aug 24, 2025
...rg/springframework/integration/file/remote/synchronizer/AbstractInboundFileSynchronizer.java
Show resolved
Hide resolved
...pringframework/integration/file/remote/synchronizer/AbstractRemoteFileSynchronizerTests.java
Outdated
Show resolved
Hide resolved
…InboundFileSynchronizer` Fixes: spring-projects#10137 When `maxFetchSize > 0`, the `AbstractInboundFileSynchronizer` performs unnecessary `Session.list()` every time. Then we go over all those files to filter. And only after filtering we apply the `maxFetchSize`. * Add a cache for remote directory entries in the `AbstractInboundFileSynchronizer` * Guard cache interaction with a `DefaultLockRegistry` per directory * Rework `AbstractInboundFileSynchronizer.transferFilesFromRemoteToLocal()` to filter all the entries of the `Session.list()` on a first call. If `maxFetchSize > 0`, cache the remaining remote files
* Fix `AbstractRemoteFileSynchronizerTests` for professional variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10137
When
maxFetchSize > 0, theAbstractInboundFileSynchronizerperforms unnecessarySession.list()every time.Then we go over all those files to filter.
And only after filtering we apply the
maxFetchSize.AbstractInboundFileSynchronizerDefaultLockRegistryper directoryAbstractInboundFileSynchronizer.transferFilesFromRemoteToLocal()to filter all the entries of theSession.list()on a first call. IfmaxFetchSize > 0, cache the remaining remote files