GH-10083: Apply NullAbility to core endpoint package
#10359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to: spring-projects#10083 Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
artembilan
requested changes
Aug 25, 2025
| @@ -68,17 +67,18 @@ public abstract class MessageProducerSupport extends AbstractEndpoint | |||
| @Nullable | |||
| private MessageReceiverObservationConvention observationConvention; | |||
|
|
|||
| @SuppressWarnings("NullAway.Init") | |||
There was a problem hiding this comment.
I believe this one is @Nullable as well.
See getOutputChannel() contact.
And then getRequiredOutputChannel()
There was a problem hiding this comment.
updated.
I did this due to I found below lifecycle method in this class.
@Override
public void afterSingletonsInstantiated() {
Assert.state(this.outputChannel != null || StringUtils.hasText(this.outputChannelName),
"'outputChannel' or 'outputChannelName' is required");
}will it not be called in some cases?
There was a problem hiding this comment.
It will be, but since that checks against one or another , both of them has to be treated equal. I guess getOutputChannel should do the trick.
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
…into jspecify-core-endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #10083