-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drop switch from Redis unlink to delete #10460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with Spring Data team, we agreed that fully dropping DEL
support is fair game from now on.
Please, consider to refine the logic just deal with UNLINK
.
Also, take a look into RedisQueueInboundGateway
, RedisQueueMessageDrivenEndpoint
and RedisMessageStore
where we still use DEL
.
Thanks
I decided to remove switch from unlink to dev |
Thank you! Let's us know, please, if you are going to that as a part of this PR or so! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just noticed:
Signed-off-by: michaldo <michaldo@github.com>
Please, use your legal name instead according to DCO requirements.
You can configure your Git client to produce a proper name for you into those commits.
This PR is functionally closed. I encountered problem of not careful switch, analyzed it and fixed. I am sure this change is safe because no modern application should be switched to delete mode. |
More performant `unlink` is not available on Redis 3. Implementation is aware that, however not careful exception handling may switch to less performant `delete` on connection exception or similar case. The switch is permanent. Maybe better choice is drop support for Redis 3, which is not maintained since 2018 Signed-off-by: Michal Domagala <michaldo@github.com>
Redis 3, target of fallback, is not maintained since 2018 Signed-off-by: Michal Domagala <michaldo@github.com>
Remove code remainings Signed-off-by: Michal Domagala <michaldo@github.com>
Signed-off-by: Michal Domagala <michaldo@github.com>
Signed-off-by: Michal Domagala <michaldo@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add your name into the @author
list of the affected class.
Also, give us your thought about other classes in Redis module which still use DEL
.
Thank you again!
Signed-off-by: Michal Domagala <michaldo@github.com>
I add myself as one of
|
Sounds reasonable. Thank you for looking over there! |
Drop support for Redis 3, which is not maintained since 2018