GH-3189: Properly handle async in ScatterGatherHandler
#10469
Merged
+63
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
approved these changes
Oct 7, 2025
| } | ||
|
|
||
| @Override | ||
| protected @Nullable Object handleRequestMessage(Message<?> requestMessage) { |
There was a problem hiding this comment.
Do we need to enumerate that a mono is returned when async is true else a AbstractIntegrationMessageBuilder is returned?
…ler` Fixes: spring-projects#3189 Despite supporting `async = true`, the `ScatterGatherHandler` does blocking in its `handleRequestMessage()` on the `gatherResultChannel.receive()` call. * Fix `ScatterGatherHandler` to handle an `async` mode via internal `Mono` for the reply object * Use pattern variable expressions for `ifs` in the `ScatterGatherHandler.doInit()` for the better readability * Extract `ScatterGatherHandler.replyFromGatherResult()` method to avoid code duplication * Document a new (fixed) functionality **Auto-cherry-pick to `6.5.x`**
|
Thank you for the update! |
cppwfs
pushed a commit
to cppwfs/spring-integration
that referenced
this pull request
Oct 8, 2025
…ler` (spring-projects#10469) * spring-projectsGH-3189: Properly handle `async` in `ScatterGatherHandler` Fixes: spring-projects#3189 Despite supporting `async = true`, the `ScatterGatherHandler` does blocking in its `handleRequestMessage()` on the `gatherResultChannel.receive()` call. * Fix `ScatterGatherHandler` to handle an `async` mode via internal `Mono` for the reply object * Use pattern variable expressions for `ifs` in the `ScatterGatherHandler.doInit()` for the better readability * Extract `ScatterGatherHandler.replyFromGatherResult()` method to avoid code duplication * Document a new (fixed) functionality * Mention `Mono` reply in the `ScatterGatherHandler` Javadocs **Auto-cherry-pick to `6.5.x`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3189
Despite supporting
async = true, theScatterGatherHandlerdoes blocking in itshandleRequestMessage()on the
gatherResultChannel.receive()call.ScatterGatherHandlerto handle anasyncmode via internalMonofor the reply objectifsin theScatterGatherHandler.doInit()for the better readabilityScatterGatherHandler.replyFromGatherResult()method to avoid code duplicationAuto-cherry-pick to
6.5.x