INT-3491: (S)FTP Delegating Session Factory

[garyrussell]

JIRA: https://jira.spring.io/browse/INT-3491

Select the session factory at runtime.

[artembilan]

Looks like a bad name 😄
How about SessionFactoryLocator because it doesn't produce new instances, but return them by their key.
So, Selector is another candidate.
Holder...
Your ideas?

[garyrussell]

SessionFactoryLocator 👍

[garyrussell]

Rebased, pushed.

[artembilan]

I think, I'm fine with the polishing.
Will be merged on its time soon

[artembilan]

Merged as 13b4fac

[vayalaivadivel]

Hi Team,
Can we have a snapshot/sample code to transfer message dynamically in sftp inbound adapter through using spring with polling frequency, host, port, user, password, path and archiveDirectory?

Thanks and Regards,
VADIVEL P M

[garyrussell]

Can you explain your use case in more detail?

[vayalaivadivel]

Hi Gary Russell,
Thanks for your quick reply. My requirement is very simple. I need to create/cofingure one SFTP Inbound Adaptor with all require properties. We are using only mule based tomcat server.
Please let me know any more details.

Thanks and Regards,
VADIVEL PM.

[garyrussell]

But that is a simple configuration using property placeholders - it's the "dynamic" piece that I don't understand.

[vayalaivadivel]

Below is the way we are going to configure SFTPInboundAdapter using xml,

<int-sftp:inbound-channel-adapter id="sftpAdapterAutoCreate"
              session-factory="sftpSessionFactory"
            channel="requestChannel"
            filename-pattern="*.txt"
            remote-directory="/foo/bar"
            preserve-timestamp="true"
            local-directory="file:target/foo"
            auto-create-local-directory="true"
            local-filename-generator-expression="#this.toUpperCase() + '.a'"
            local-filter="myFilter"
            temporary-file-suffix=".writing"
            delete-remote-files="false">
        <int:poller fixed-rate="1000"/>
</int-sftp:inbound-channel-adapter>

Please let me know any other way to do this using annotations.

[garyrussell]

Any of those properties can be replaced with a property placeholder, e.g.

filename-pattern="${my.filename.pattern}"

See the Spring Reference about property placeholders.

For annotated java configuration, consider using the java dsl...

    @Bean
    public IntegrationFlow sftpInboundFlow() {
        return IntegrationFlows
                .from(Sftp.inboundAdapter(sftpSessionFactory())
                                .preserveTimestamp(true)
                                .remoteDirectory("sftpSource")
                                .regexFilter(".*\\.txt$")
                                .localFilenameExpression("#this.toUpperCase() + '.a'")
                                .localDirectory(this.sftpServer.getTargetLocalDirectory()),
                        e -> e.id("sftpInboundAdapter"))
                .channel(MessageChannels.queue("sftpInboundResultChannel"))
                .get();
    }

[vayalaivadivel]

Thanks a lot Gary. I have done this. I have to write JUnit or Groovy test case to test my changes. Can you please guide me with some sample code to test this?

[garyrussell]

There are lots of tests in the framework itself.

In future, please don't ask questions like this on an old Pull Request, use Stack Overflow (tag spring-integration) or a github issue.