GH-2748: Add bean definition info into exceptions #2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2748 In many cases Spring Integration stack traces doesn't contain any relations to end-user code. Just because a target project code mostly contains only a configuration for out-of-the-box components without any custom code. When exception is thrown from such an out-of-the-box component, it is hard from the stack trace to determine a configuration source for those components. * Add a logic into the `IntegrationObjectSupport` to obtain a its own `BeanDefinition` from the `BeanFactory` to include a `resource` and `source` (if any) into the `toString()` representation, as well as add a new `getBeanDescription()` to get such an info at runtime * The `toString()` is simply used by `this` reference in the message for `MessagingException` thrown from the `IntegrationObjectSupport` implementations * Modify an exception message for the `MessageTransformingHandler` and `MessageFilter` to make it based on `this`. The `AbstractMessageHandler` already includes `this` into its exception message * Modify a `AbstractConsumerEndpointParser` and `AbstractAmqpInboundAdapterParser` (as a sample) to include a `resource` and `source` into a `MessageHandler` `BeanDefinition`. * Include an `IntegrationFlow` `BeanDefinition` `resource` (`@Configuration` class) and its bean method as a `source` into all child beans declared during flow parsing in the `IntegrationFlowBeanPostProcessor` * Add `IntegrationFlowRegistrationBuilder.setSource()` for manually registered flows: there is no configuration parsing phase to extract such an info from `BeanFactory` * Propagate that `source` into all the child beans provided by the `IntegrationFlow` * Modify a `LambdaMessageProcessor` exception message to include a method info in case of `InvocationTargetException`
|
I would say we can merge it with what we have so far. |
`IntegrationObjectSupport` to avoid tests modifications for mocking directly into `ConfigurableListableBeanFactory`. Use `instanceof` instead in the `getBeanDescription()`
|
Quite a lot of test failures (travis) |
|
Yep! Fighting with that... |
garyrussell
reviewed
Jul 12, 2019
| public void sendTimeoutDefault() { | ||
| @Test | ||
| // INT-1154 | ||
| void sendTimeoutDefault() { |
There was a problem hiding this comment.
?? Why the newlines on all of these?
There was a problem hiding this comment.
Looks like fresh IDEA code formatting...
Thanks for heads up. I will remove it altogether.
to rely on the `NamedComponent` for channel names instead of always call `toString()` which is now much more than just a bean name * Don't describe a `componentName` if it is the same as a `beanName` * Check for parent `BeanDefinition` in the `IntegrationFlowBeanPostProcessor` before calling its meta-info * Fix tests according new `IntegrationObjectSupport.toString()` behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2748
In many cases Spring Integration stack traces doesn't contain any
relations to end-user code.
Just because a target project code mostly contains only a configuration
for out-of-the-box components without any custom code.
When exception is thrown from such an out-of-the-box component, it is
hard from the stack trace to determine a configuration source for those
components.
IntegrationObjectSupportto obtain a its ownBeanDefinitionfrom theBeanFactoryto include aresourceandsource(if any) into thetoString()representation, as well as adda new
getBeanDescription()to get such an info at runtimetoString()is simply used bythisreference in the messagefor
MessagingExceptionthrown from theIntegrationObjectSupportimplementations
MessageTransformingHandlerandMessageFilterto make it based onthis.The
AbstractMessageHandleralready includesthisinto its exceptionmessage
AbstractConsumerEndpointParserandAbstractAmqpInboundAdapterParser(as a sample) to include aresourceand
sourceinto aMessageHandlerBeanDefinition.IntegrationFlowBeanDefinitionresource(
@Configurationclass) and its bean method as asourceinto allchild beans declared during flow parsing in the
IntegrationFlowBeanPostProcessorIntegrationFlowRegistrationBuilder.setSource()for manuallyregistered flows: there is no configuration parsing phase to extract
such an info from
BeanFactorysourceinto all the child beans provided by theIntegrationFlowLambdaMessageProcessorexception message to include amethod info in case of
InvocationTargetException