Introduce a ReceiveMessageAdvice
#3265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate an `AbstractMessageSourceAdvice` in favor of
`default` method in the `MessageSourceMutator`
* Move a `applyReceiveOnlyAdviceChain()` logic into the `AbstractPollingEndpoint`:
now both `PollingConsumer` and `SourcePollingChannelAdapter` can use
`ReceiveMessageAdvice`
* Introduce a `SimpleActiveIdleReceiveMessageAdvice` based already
on the `ReceiveMessageAdvice` and deprecate a `SimpleActiveIdleMessageSourceAdvice`
which is fully replaceable with newly introduced `SimpleActiveIdleReceiveMessageAdvice`
* Add `@SuppressWarnings("deprecation")` for those out-of-the-box `ReceiveMessageAdvice`
implementation which still use an `AbstractMessageSourceAdvice` for
backward compatibility
* Document a new feature and give the `MessageSourceMutator` a new meaning
garyrussell
suggested changes
Apr 28, 2020
|
|
||
| @Override | ||
| @Nullable | ||
| public Message<?> afterReceive(@Nullable Message<?> result, Object source) { |
There was a problem hiding this comment.
Wouldn't something like Advisable<T> be better than Object?
There was a problem hiding this comment.
Well, in most cases it is really about both MessageSource and PollableChannel, so even with generic argument it still going to be an Object 😄
I thought about a Supplier for both those interfaces, but this is not what we are going to use with the receive(timeout).
Therefore I'm OK to stick with an Object for a source argument.
artembilan
commented
Apr 28, 2020
akuma8
pushed a commit
to akuma8/spring-integration
that referenced
this pull request
May 9, 2020
* Introduce a `ReceiveMessageAdvice`
* Deprecate an `AbstractMessageSourceAdvice` in favor of
`default` method in the `MessageSourceMutator`
* Move a `applyReceiveOnlyAdviceChain()` logic into the `AbstractPollingEndpoint`:
now both `PollingConsumer` and `SourcePollingChannelAdapter` can use
`ReceiveMessageAdvice`
* Introduce a `SimpleActiveIdleReceiveMessageAdvice` based already
on the `ReceiveMessageAdvice` and deprecate a `SimpleActiveIdleMessageSourceAdvice`
which is fully replaceable with newly introduced `SimpleActiveIdleReceiveMessageAdvice`
* Add `@SuppressWarnings("deprecation")` for those out-of-the-box `ReceiveMessageAdvice`
implementation which still use an `AbstractMessageSourceAdvice` for
backward compatibility
* Document a new feature and give the `MessageSourceMutator` a new meaning
* * Fix language in the `polling-consumer.adoc`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractMessageSourceAdvicein favor ofdefaultmethod in theMessageSourceMutatorapplyReceiveOnlyAdviceChain()logic into theAbstractPollingEndpoint:now both
PollingConsumerandSourcePollingChannelAdaptercan useReceiveMessageAdviceSimpleActiveIdleReceiveMessageAdvicebased alreadyon the
ReceiveMessageAdviceand deprecate aSimpleActiveIdleMessageSourceAdvicewhich is fully replaceable with newly introduced
SimpleActiveIdleReceiveMessageAdvice@SuppressWarnings("deprecation")for those out-of-the-boxReceiveMessageAdviceimplementation which still use an
AbstractMessageSourceAdviceforbackward compatibility
MessageSourceMutatora new meaning